[AppKit] Add constructors for NSMenuToolbarItem classes - #15087
Merged
Conversation
chamons
commented
May 20, 2022
chamons
commented
Contributor
- Fixes AppKit.NSMenuToolbarItem is missing identifier constructor in MacCatalyst #15069
Contributor
Author
|
I believe this is correct, specially the ctor XAMCORE_5_0 bit, but I am not certain. Please double check my work here. |
Collaborator
Collaborator
ðŧ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed ðŧâ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
Collaborator
ðŧ [PR Build] Tests on macOS Mac Catalina (10.15) passed ðŧâ All tests on macOS Mac Catalina (10.15) passed. Pipeline on Agent |
Collaborator
ð [PR Build] API Diff ðAPI diff (for current PR)âđïļ API Diff (from PR only) (please review changes) .NETXamarin vs .NETAPI diff (vs stable)â API Diff from stable .NETXamarin vs .NETGenerator diffâđïļ Generator Diff (please review changes) Pipeline on Agent XAMBOT-1043.Monterey' |
Collaborator
rolfbjarne
approved these changes
May 23, 2022
dalexsoto
approved these changes
May 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
