[coremotion] Add nullability to (generated and manual) bindings - #15072
Merged
Conversation
Collaborator
Collaborator
ðŧ [PR Build] Tests on macOS Mac Catalina (10.15) passed ðŧâ All tests on macOS Mac Catalina (10.15) passed. Pipeline on Agent |
Collaborator
ð [PR Build] API Diff ðAPI diff (for current PR)âđïļ API Diff (from PR only) (please review changes) .NETXamarin vs .NETAPI diff (vs stable)â API Diff from stable .NETXamarin vs .NETGenerator diffâ Generator Diff (no change) Pipeline on Agent XAMBOT-1044.Monterey' |
mandel-macaque
approved these changes
May 19, 2022
Collaborator
â [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed âFailed tests are:
Pipeline on Agent |
dalexsoto
approved these changes
May 20, 2022
rolfbjarne
approved these changes
May 20, 2022
chamons
approved these changes
May 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to bring nullability changes to CoreMotion.
Following the steps here:
nullable enableto all manual files that are not "API_SOURCES" in src/frameworks.sources and making the required nullability changes