Skip to content

[corespotlight] Add nullability to (generated and manual) bindings - #15023

Merged
tj-devel709 merged 2 commits into
dotnet:mainfrom
tj-devel709:Nullable-CoreSpotlight
May 17, 2022
Merged

[corespotlight] Add nullability to (generated and manual) bindings#15023
tj-devel709 merged 2 commits into
dotnet:mainfrom
tj-devel709:Nullable-CoreSpotlight

Conversation

@tj-devel709

Copy link
Copy Markdown
Member

This PR aims to bring nullability changes to CoreSpotlight.
Following the steps here:

  1. I am adding nullable enable to all manual files that are not "API_SOURCES" in src/frameworks.sources and making the required nullability changes

@tj-devel709 tj-devel709 added the not-notes-worthy Ignore for release notes label May 13, 2022
@tj-devel709 tj-devel709 added this to the Future milestone May 13, 2022
@tj-devel709
tj-devel709 requested a review from dalexsoto as a code owner May 13, 2022 15:16
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1106.Monterey'
Hash: c29f5edcaa2be1230acfa2bbe1230e4749e263f0

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

ðŸ’ŧ [PR Build] Tests on macOS Mac Catalina (10.15) passed ðŸ’ŧ

✅ All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: c29f5edcaa2be1230acfa2bbe1230e4749e263f0

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

📋 [PR Build] API Diff 📋

API Current PR diff

â„đïļ API Diff (from PR only) (please review changes)

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

API diff

✅ API Diff from stable

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

Generator diff

✅ Generator Diff (no change)

Pipeline on Agent XAMBOT-1036.Monterey'
Hash: c29f5edcaa2be1230acfa2bbe1230e4749e263f0

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

  • xammac_tests
  • monotouch-test

Pipeline on Agent
Hash: c29f5edcaa2be1230acfa2bbe1230e4749e263f0

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ [CI Build] Tests passed on VSTS: simulator tests iOS. ✅

Tests passed on VSTS: simulator tests iOS.

🎉 All 148 tests passed 🎉

Pipeline on Agent XAMBOT-1108.Monterey'
Merge c29f5ed into 4d3ef30

@tj-devel709
tj-devel709 merged commit 5c8e3dd into dotnet:main May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

not-notes-worthy Ignore for release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants