Skip to content

[spritekit] Add nullability to (generated and manual) bindings - #14883

Merged
tj-devel709 merged 1 commit into
dotnet:mainfrom
tj-devel709:Nullable-SpriteKit
May 4, 2022
Merged

[spritekit] Add nullability to (generated and manual) bindings#14883
tj-devel709 merged 1 commit into
dotnet:mainfrom
tj-devel709:Nullable-SpriteKit

Conversation

@tj-devel709

Copy link
Copy Markdown
Member

This PR aims to bring nullability changes to SpriteKit.
Following the steps here:

  1. Changing any == null or != null to is null and is not null

@tj-devel709 tj-devel709 added the not-notes-worthy Ignore for release notes label May 3, 2022
@tj-devel709 tj-devel709 added this to the Future milestone May 3, 2022
@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

📋 [PR Build] API Diff 📋

API Current PR diff

â„đïļ API Diff (from PR only) (please review changes)

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

API diff

✅ API Diff from stable

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

Generator diff

✅ Generator Diff (no change)

Pipeline on Agent XAMBOT-1102.Monterey
Hash: e0263cf3003dd462cb44c0060c32f0127ff256c5

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1106.Monterey'
Hash: e0263cf3003dd462cb44c0060c32f0127ff256c5

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

❌ [PR Build] Tests on macOS Mac Catalina (10.15) failed ❌

Failed tests are:

  • introspection

Pipeline on Agent
Hash: e0263cf3003dd462cb44c0060c32f0127ff256c5

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ [CI Build] Tests passed on VSTS: simulator tests iOS. ✅

Tests passed on VSTS: simulator tests iOS.

🎉 All 148 tests passed 🎉

Pipeline on Agent XAMBOT-1106.Monterey'
Merge e0263cf into 1e938b1

@tj-devel709
tj-devel709 merged commit 7a8f47a into dotnet:main May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

not-notes-worthy Ignore for release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants