Skip to content

[dotnet/Templates] Remove preview language - #14842

Merged
rolfbjarne merged 1 commit into
dotnet:mainfrom
pjcollins:rm-preview-templates
Apr 29, 2022
Merged

[dotnet/Templates] Remove preview language#14842
rolfbjarne merged 1 commit into
dotnet:mainfrom
pjcollins:rm-preview-templates

Conversation

@pjcollins

Copy link
Copy Markdown
Member

Removes the "(Preview)" string from the title of the .NET templates.

Removes the "(Preview)" string from the title of the .NET templates.
@pjcollins
pjcollins requested a review from rolfbjarne April 28, 2022 16:53
@pjcollins

Copy link
Copy Markdown
Member Author

@rolfbjarne I'm not sure what is needed to update the localization for these templates, are more changes required in this PR for .lcl files or anything else? Or is that something that happens after this is merged?

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

📋 [PR Build] API Diff 📋

API Current PR diff

✅ API Diff (from PR only) (no change)

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

API diff

✅ API Diff from stable

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

Generator diff

â„đïļ Generator Diff (please review changes)

Pipeline on Agent XAMBOT-1017.Monterey'
Hash: 140b555696b2b5f9f79b57c448228b39b0d261e7

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1023.Monterey
Hash: 140b555696b2b5f9f79b57c448228b39b0d261e7

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

  • dontlink
  • monotouch-test

Pipeline on Agent
Hash: 140b555696b2b5f9f79b57c448228b39b0d261e7

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

ðŸ’ŧ [PR Build] Tests on macOS Mac Catalina (10.15) passed ðŸ’ŧ

✅ All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: 140b555696b2b5f9f79b57c448228b39b0d261e7

@chamons

chamons commented Apr 28, 2022

Copy link
Copy Markdown
Contributor

@tj-devel709 - Can you answer the localization question?

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ [CI Build] Tests passed on VSTS: simulator tests iOS. ✅

Tests passed on VSTS: simulator tests iOS.

🎉 All 146 tests passed 🎉

Pipeline on Agent XAMBOT-1017.Monterey'
Merge 140b555 into 717b141

@rolfbjarne

Copy link
Copy Markdown
Member

@pjcollins localization should happen automatically once the PR is merged.

@rolfbjarne
rolfbjarne merged commit e1073eb into dotnet:main Apr 29, 2022
@rolfbjarne

Copy link
Copy Markdown
Member

/sudo backport release/6.0.3xx

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

Backport Job to branch release/6.0.3xx Created! The magic is happening here

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6089247 for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants