Repository navigation
fix(windows): realign GhosttyActionTag ordinals after upstream rebase - #552
Merged
Merged
Conversation
The 2026-06 upstream sync inserted GHOSTTY_ACTION_SELECTION_CHANGED at index 51 of ghostty_action_tag_e, auto-shifting every later tag by +1. The hand-maintained C# mirror was not updated -- the layout test's "re-verify against include/ghostty.h" step is manual and was missed, and there is no C# CI to catch it -- so eight dispatched tags pointed at the wrong upstream action on Windows: ShowChildExited 55->56, ProgressReport 56->57, StartSearch 59->60, EndSearch 60->61, SearchTotal 61->62, SearchSelected 62->63, PromptReady 65->66, FirstRender 66->67 Uncorrected, e.g. ProgressReport=55 resolved to OPEN_URL and FirstRender to PROMPT_READY -- progress bars, search counts, prompt-ready and first-render notifications were all misrouted. Realign the enum and the pinned ordinals in GhosttyActionsLayoutTests to the current header. Not built locally: the C# app only compiles on Windows (CsWin32). Values verified by direct enumeration of include/ghostty.h. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
4 tasks
deblasis
marked this pull request as ready for review
June 26, 2026 08:35
deblasis
added a commit
that referenced
this pull request
Jul 18, 2026
…#552) The 2026-06 upstream sync inserted GHOSTTY_ACTION_SELECTION_CHANGED at index 51 of ghostty_action_tag_e, auto-shifting every later tag by +1. The hand-maintained C# mirror was not updated -- the layout test's "re-verify against include/ghostty.h" step is manual and was missed, and there is no C# CI to catch it -- so eight dispatched tags pointed at the wrong upstream action on Windows: ShowChildExited 55->56, ProgressReport 56->57, StartSearch 59->60, EndSearch 60->61, SearchTotal 61->62, SearchSelected 62->63, PromptReady 65->66, FirstRender 66->67 Uncorrected, e.g. ProgressReport=55 resolved to OPEN_URL and FirstRender to PROMPT_READY -- progress bars, search counts, prompt-ready and first-render notifications were all misrouted. Realign the enum and the pinned ordinals in GhosttyActionsLayoutTests to the current header. Not built locally: the C# app only compiles on Windows (CsWin32). Values verified by direct enumeration of include/ghostty.h. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
deblasis
added a commit
that referenced
this pull request
Jul 29, 2026
…#552) The 2026-06 upstream sync inserted GHOSTTY_ACTION_SELECTION_CHANGED at index 51 of ghostty_action_tag_e, auto-shifting every later tag by +1. The hand-maintained C# mirror was not updated -- the layout test's "re-verify against include/ghostty.h" step is manual and was missed, and there is no C# CI to catch it -- so eight dispatched tags pointed at the wrong upstream action on Windows: ShowChildExited 55->56, ProgressReport 56->57, StartSearch 59->60, EndSearch 60->61, SearchTotal 61->62, SearchSelected 62->63, PromptReady 65->66, FirstRender 66->67 Uncorrected, e.g. ProgressReport=55 resolved to OPEN_URL and FirstRender to PROMPT_READY -- progress bars, search counts, prompt-ready and first-render notifications were all misrouted. Realign the enum and the pinned ordinals in GhosttyActionsLayoutTests to the current header. Not built locally: the C# app only compiles on Windows (CsWin32). Values verified by direct enumeration of include/ghostty.h. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
deblasis
added a commit
that referenced
this pull request
Aug 10, 2026
…#552) The 2026-06 upstream sync inserted GHOSTTY_ACTION_SELECTION_CHANGED at index 51 of ghostty_action_tag_e, auto-shifting every later tag by +1. The hand-maintained C# mirror was not updated -- the layout test's "re-verify against include/ghostty.h" step is manual and was missed, and there is no C# CI to catch it -- so eight dispatched tags pointed at the wrong upstream action on Windows: ShowChildExited 55->56, ProgressReport 56->57, StartSearch 59->60, EndSearch 60->61, SearchTotal 61->62, SearchSelected 62->63, PromptReady 65->66, FirstRender 66->67 Uncorrected, e.g. ProgressReport=55 resolved to OPEN_URL and FirstRender to PROMPT_READY -- progress bars, search counts, prompt-ready and first-render notifications were all misrouted. Realign the enum and the pinned ordinals in GhosttyActionsLayoutTests to the current header. Not built locally: the C# app only compiles on Windows (CsWin32). Values verified by direct enumeration of include/ghostty.h. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
deblasis
added a commit
that referenced
this pull request
Aug 21, 2026
…#552) The 2026-06 upstream sync inserted GHOSTTY_ACTION_SELECTION_CHANGED at index 51 of ghostty_action_tag_e, auto-shifting every later tag by +1. The hand-maintained C# mirror was not updated -- the layout test's "re-verify against include/ghostty.h" step is manual and was missed, and there is no C# CI to catch it -- so eight dispatched tags pointed at the wrong upstream action on Windows: ShowChildExited 55->56, ProgressReport 56->57, StartSearch 59->60, EndSearch 60->61, SearchTotal 61->62, SearchSelected 62->63, PromptReady 65->66, FirstRender 66->67 Uncorrected, e.g. ProgressReport=55 resolved to OPEN_URL and FirstRender to PROMPT_READY -- progress bars, search counts, prompt-ready and first-render notifications were all misrouted. Realign the enum and the pinned ordinals in GhosttyActionsLayoutTests to the current header. Not built locally: the C# app only compiles on Windows (CsWin32). Values verified by direct enumeration of include/ghostty.h. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem (regression introduced by the 2026-06 upstream sync)
The sync inserted
GHOSTTY_ACTION_SELECTION_CHANGEDat index 51 ofghostty_action_tag_e, which auto-shifts every later C ordinal +1. The hand-maintained C# mirror (GhosttyActionTag) wasn't updated — the layout test's "re-verify againstinclude/ghostty.h" is a manual grep that was missed, and there's no C# CI to catch it. Result: 8 dispatched tags pointed at the wrong upstream action on Windows:OPEN_URLSHOW_CHILD_EXITEDCOMMAND_FINISHEDSTART_SEARCHEND_SEARCHSEARCH_TOTALCOPY_TITLE_TO_CLIPBOARDPROMPT_READYSo progress bars, search counts, prompt-ready and first-render notifications were silently misrouted on Windows.
Fix
Realign the 8 ordinals in
GhosttyActionTagand the pinned values inGhosttyActionsLayoutTeststo the current header. Pure data change; no behavior added (handlingSELECTION_CHANGEDitself is #550, stacked on this).Not built/tested locally — the C# app only compiles on Windows (CsWin32 source-gen fails on macOS), and the fork has no C# CI. Ordinals were verified by direct enumeration of
include/ghostty/ghostty.h. Please runGhosttyActionsLayoutTestson Windows before merging. (Worth adding a CI job that runsGhostty.Testsso this class of drift fails automatically on future syncs.)🤖 Generated with Claude Code