Repository navigation
extractAllTo() no longer preserves linux file permissions #530
Description
In version 0.5.15, the following function call: zip.extractAllTo(unzipFileLocation, true, true)
Is supposed to keepOriginalPermission when the third argument is true. Up to version 0.5.14 this worked correctly, preserving Linux rwx permissions. But as of 0.5.15, it is as if there is a umask of 0o117 when unpacking. It also adds write permission for group.
A file in the zip archive was saved with these permissions:
-rwxr-x--- 1 user staff 9744 Aug 12 2024 opscompass.sh*
But unzipped as:
-rw-rw---- 1 user staff 9744 Aug 12 2024 opscompass.sh*
VERIFIED: 0.5.14 still works correctly
Activity
NickAllmakerOpsCompass commentedon Aug 12, 2024
I'm not 100% sure but it looks like the issue was introduced by the change to number parsing in #518. Specifically, I think that when fileAttr switched from just doing bitwise arithmetic to the uint16 helper, that caused it to start turning fileAttr into 0.
Fix cli npm package installs on Linux/MacOS
Fix cli npm package installs on Linux/MacOS
Fix cli npm package installs on Linux/MacOS (#2589)
chadlwilson commentedon Aug 19, 2024
This was fixed by #531 - @cthackers would you be able to cut a 0.5.16 release to fix this regression? 🙏
Downgrade adm-zip to 0.5.14
Downgrade adm-zip to 0.5.14
cthackers commentedon Jul 10, 2026
Fixed