Repository navigation
Use type awareness in timescaledb demo - #50
Merged
Merged
Conversation
vixentael
reviewed
Apr 17, 2022
| grafana: | ||
| image: grafana/grafana:8.3.0 | ||
| # Dirty hack: run as root to deal with permissions | ||
| user: root |
I don't know when docker-compose started to use `-` instead of `_` for container names but here we are.
This will fix a problem with incorrect rendering of bars in grafana. It could be fixed with `::text` sql conversion, but the Acra doesn't support it yet.
Lagovas
approved these changes
Apr 18, 2022
Lagovas
left a comment
Lagovas
left a comment
Contributor
There was a problem hiding this comment.
lgtm. merge after releasing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables type awareness support for a
deviceandunit_idfields orcpu_temptable. It also fixes grafana to use TLS so the Acra can correctly decrypt the records.UPDATE: fixed
There is one issue though. The readme says that the grafana for demo data should look like: But in my case it looks like:
I guess that's because the
unit_idbecame an int, so grafana interprets it as a numerical value and draws a bar of its height. Don't really know how to fix it, so I hope you will help.Also, please check if maybe I missed something.