Skip to content

ci: add a ci-ok job aggregating the required jobs - #955

Merged
ndeloof merged 1 commit into
compose-spec:mainfrom
ndeloof:ci-ok
Oct 22, 2026
Merged

ndeloof merged 1 commit into
compose-spec:mainfrom
ndeloof:ci-ok

Conversation

@ndeloof

@ndeloof ndeloof commented Oct 22, 2026

Copy link
Copy Markdown
Collaborator

What this PR does, in one sentence

Adds a ci-ok job that aggregates the gating jobs of the CI, so that it can become the only required status check of the repository.

Context

The required checks are configured by job name, and the test job is a matrix: the checks are named after the Go versions it runs, such as test (1.25, ubuntu-latest). When the versions of the matrix change, as in the move to Go 1.26 and 1.27, the old names are still required but never reported again, and the merge stays blocked until someone edits the repository settings by hand. The same happens whenever a job is renamed or split.

What the PR brings

  • A ci-ok job runs after validate, lint, static-checks and test, even when one of them failed (if: always()), and fails unless every one of them succeeded; a skipped or cancelled job counts as a failure. It has no permissions and does not check anything out.
  • api-compat and vulncheck are left out on purpose: they are informational and never block a merge.
  • Once this is merged, the repository settings can require ci-ok alone instead of the per-version test (...) checks, and the CI can then evolve (Go versions, job names, matrix) without touching the settings again. That settings change is not part of this PR.

No change to the existing jobs.

🤖 Generated with Claude Code

The required status checks of the repository are named after matrix
entries, such as 'test (1.25, ubuntu-latest)': changing the Go versions of
the matrix leaves them waiting forever for a job that no longer exists.
ci-ok fails when any of the gating jobs did not succeed, so that it can
become the only required check.

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof
ndeloof requested a review from glours as a code owner October 22, 2026 15:47
@ndeloof
ndeloof merged commit f242028 into compose-spec:main Oct 22, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant