Repository navigation
ci: add a ci-ok job aggregating the required jobs - #955
Merged
Merged
Conversation
The required status checks of the repository are named after matrix entries, such as 'test (1.25, ubuntu-latest)': changing the Go versions of the matrix leaves them waiting forever for a job that no longer exists. ci-ok fails when any of the gating jobs did not succeed, so that it can become the only required check. Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does, in one sentence
Adds a
ci-okjob that aggregates the gating jobs of the CI, so that it can become the only required status check of the repository.Context
The required checks are configured by job name, and the
testjob is a matrix: the checks are named after the Go versions it runs, such astest (1.25, ubuntu-latest). When the versions of the matrix change, as in the move to Go 1.26 and 1.27, the old names are still required but never reported again, and the merge stays blocked until someone edits the repository settings by hand. The same happens whenever a job is renamed or split.What the PR brings
ci-okjob runs aftervalidate,lint,static-checksandtest, even when one of them failed (if: always()), and fails unless every one of them succeeded; a skipped or cancelled job counts as a failure. It has no permissions and does not check anything out.api-compatandvulncheckare left out on purpose: they are informational and never block a merge.ci-okalone instead of the per-versiontest (...)checks, and the CI can then evolve (Go versions, job names, matrix) without touching the settings again. That settings change is not part of this PR.No change to the existing jobs.
🤖 Generated with Claude Code