Skip to content

Add x- extensions to depends_on - #659

Merged
ndeloof merged 1 commit into
compose-spec:mainfrom
jhrotko:depends-on-x
Jul 9, 2024
Merged

ndeloof merged 1 commit into
compose-spec:mainfrom
jhrotko:depends-on-x

Conversation

@jhrotko

@jhrotko jhrotko commented Jul 9, 2024 •

Copy link
Copy Markdown
Contributor

Add x-* extensions to depends_on in compose-spec.

fixes: docker/compose#11930

relates: https://docker.atlassian.net/browse/COMP-650

Signed-off-by: Joana Hrotko <joana.hrotko@docker.com>
@ndeloof
ndeloof merged commit 300b0ed into compose-spec:main Jul 9, 2024
ndeloof added a commit that referenced this pull request Oct 21, 2026
umask sets the initial file mode creation mask of the container's
processes (entrypoint, exec and healthcheck), as proposed by
#659 and made available by the engine in docker 29.8
(HostConfig.Umask, docker/cli#7108).

The model keeps a *uint32 so that an explicit `umask: 0`, which masks no
permission bit, stays distinct from an omitted or null umask, where the
runtime default applies. A value is written like a YAML integer: a
leading 0 or a 0o prefix makes it octal, so `077` and `0o77` are 63
while `77` is 77. Strings, including interpolated ones, are parsed the
same way and rejected when they do not fit in 32 bits.

The attribute belongs to the container specification, so it is accepted
by services, jobs and pre_start init containers, and a pre_start step
inherits the umask of its service.

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Docker compose does not ignore extension fields under long form depends_on

2 participants