Skip to content

When components / flags selected --> maintain consistency in coverage data across repo overview #1269

Open

Description

@jerrodcodecov

What product do you want to improve?
Repo overview page

Is your feature request related to a problem? Please describe.
Right now, when you select certain set of components or flags on a given branch, it's actually not obviously in the file tree what the overall coverage is for the selected set of components or flags

image

Describe the solution you'd like
I think it would make sense to include a "total" or "sub-total" in the file tree view

Describe alternatives you've considered
Alternatively, we could also have the sunburst, coverage over time and repo coverage numbers update dynamically as components are selected.

If we don't take this approach, we should additionally clarify that the "selected components / flags" are only applicable to the file tree, and not metrics "above the line"

image

Additional context
Brought up by an enterprise customer

### Tasks
- [ ] https://github.com/codecov/engineering-team/issues/1453
- [ ] https://github.com/codecov/engineering-team/issues/1442
- [ ] https://github.com/codecov/engineering-team/issues/1455

Activity

  1. jerrodcodecov commented on Mar 12, 2024

    @jerrodcodecov
    Author

    @codecovdesign seeking an update on ingestion on this matter, thanks!

  2. codecovdesign commented on Mar 12, 2024

    @codecovdesign
    Contributor

    @jerrodcodecov thanks ping, marking in-discovery, adding to design sprint (upcoming) and will finalize/prep to dev ready

  3. codecovdesign commented on Mar 18, 2024

    @codecovdesign
    Contributor

    @katia-sentry here's demo/prototype based on the description suggestion. The design can be broken down in different ways and depending on the constraints the page could work together or separately; here are areas it'd be great to look at:

    • If user applies selection to sunburst, the files match the selection
    • If filters are applied subtotal of the lines shown, per the component/flag
    • If either are applied, the summary atop also aligns to the main selection
      • this could be one part that doesn't coordinate to the selection (remains as repo data)
    apply_filters.mov

    Could we schedule a design/eng discovery around this one?

  4. katia-sentry commented on Mar 18, 2024

    @katia-sentry
    Contributor

    @codecovdesign yes we can schedule a sync for this with @RulaKhaled and @rohitvinnakota-codecov

  5. codecovdesign commented on Mar 20, 2024

    @codecovdesign
    Contributor

    review with @rohitvinnakota-codecov @RulaKhaled 3/20

    • create bug issue for sunburst path vs file path (sunburst showing) Sunburst shows files that code tree doesn't #1442
    • Rola: partial to show the summary as a constant (showing repo data)
      • related would be then to move the filters above the charts since it controls the data below
    • initial iteration to consider: display sub-totals below files table when filters are applied
  6. codecovdesign commented on Mar 26, 2024

    @codecovdesign
    Contributor

    review 2 with @rohitvinnakota-codecov and @RulaKhaled

    Next steps are to resolve the bug findings, then revisit the updates to filtering / sunburst etc

  7. vlad-ko commented on Jun 17, 2024

    @vlad-ko

    Do we have any update that I could share with the customers?

  8. codecovdesign commented on Jun 17, 2024

    @codecovdesign
    Contributor

    @vlad-ko it looks like the initial blockers have been addressed; tentatively moving #1453 to dev ready cc @katia-sentry

  9. katia-sentry commented on Jun 17, 2024

    @katia-sentry
    Contributor

    Thanks @vlad-ko @codecovdesign. I've added #1453 to next sprint

  10. nikosatwork commented on Jun 18, 2025

    @nikosatwork

    Hi @vlad-ko @katia-sentry @codecovdesign. I wanted to follow up on this feature. Is there a version available I could test perhaps? Thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    in discoveryThe design, product, and specifications require refinement

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions