Skip to content

Remove experimental.newConfig option in Vite plugin v1 - #16363

Merged
petebacondarwin merged 1 commit into
vite-plugin-v1from
james/remove-v1-new-config
Oct 19, 2026
Merged

petebacondarwin merged 1 commit into
vite-plugin-v1from
james/remove-v1-new-config

Conversation

@jamesopstad

Copy link
Copy Markdown
Contributor

Remove the experimental.newConfig option from Vite plugin v1

Vite plugin v1 now supports Wrangler configuration files only. Projects using cloudflare.config.ts for configuration should upgrade to Vite plugin v2 beta.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: experimental feature

A picture of a cute animal (not mandatory, but encouraged)

@changeset-bot

changeset-bot Bot commented Oct 19, 2026

Copy link
Copy Markdown

ðŸĶ‹ Changeset detected

Latest commit: 8e584f4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/vite-plugin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Oct 19, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/@cloudflare/vite-plugin@16363

commit: 8e584f4

@ask-bonk

ask-bonk Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

LGTM!

github run

@jamesopstad
jamesopstad marked this pull request as ready for review October 19, 2026 14:53
@workers-devprod
workers-devprod requested review from a team and dario-piotrowicz and removed request for a team October 19, 2026 14:53
@workers-devprod

workers-devprod commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@clanky-the-clanker

Copy link
Copy Markdown

💎 Approved with comments — This pull request removes the experimental.newConfig path and its related code, and I found no correctness, security or performance problems. One release-notes comment: the changeset does not mention that the cf-vite binary was also removed.

Findings: 1 warning

The decision is advisory: this comment never approves, blocks or requests changes on the pull request.

🔧 Fix with your agent

Paste the following into your coding agent to investigate and fix these issues.

Fix the following code review issues found in pull request #16363.

Before making changes, review each issue and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g., the fix would require disproportionate changes
  for minimal ROI, or the finding is factually incorrect), explain why
- If you need to clarify something before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order

## WARNING (1)

### [Release] The changeset does not mention that the `cf-vite` bin entry and the `bin` directory were removed from the published package. Earlier releases announced this binary, and tooling that spawns it will fail after upgrading. Add a line to the changeset.
- **File:** .changeset/vite-v1-remove-new-config.md:7

🚀 Release: ⚠ïļ 1 warning

The changeset covers the experimental.newConfig removal but does not mention that the cf-vite binary was also removed

Recommendation: 📝 Minor Comments

  • [WARNING] The changeset does not mention that the cf-vite bin entry and the bin directory were removed from the published package. Earlier releases announced this binary, and tooling that spawns it will fail after upgrading. Add a line to the changeset. (.changeset/vite-v1-remove-new-config.md:7)
View full review

Deleting .changeset/vite-v1-preview-domain-traffic.md and .changeset/vite-v1-runtime-types-release.md is correct. Both describe unreleased changes to the experimental config path that this pull request removes, so they should not ship.

[WARNING] The release notes do not mention that the cf-vite delegate was removed. package.json no longer has the bin.cf-vite entry, and bin is removed from files. Earlier releases announced this binary in CHANGELOG.md, describing it as an internal delegate spawned by Cloudflare tooling. Any tooling that still spawns cf-vite will fail after it upgrades. Please add a line to .changeset/vite-v1-remove-new-config.md noting the removal.


✅ All other checks passed

🔒 Security: ✅ LGTM

The change removes code. It adds no new inputs, endpoints, secrets or privilege changes. The legacy wrangler.json output path in plugins/config.ts is the only output path left, and it writes outputConfig to the client output directory the same way as before.


📖 AGENTS.md: ✅ LGTM

The packages/vite-plugin-cloudflare/AGENTS.md sections about the removed experimental config were deleted along with the code.


📋 Code Quality: ✅ LGTM

This pull request removes experimental.newConfig, the cf-vite delegate, the Build Output code paths, the experimental-* playgrounds and their tests. I searched the package for leftover references to newConfig, build-output, cf-vite, @cloudflare/config, cfBuildOutput and the removed playgrounds and found none. The workerd, @cloudflare/config, @cloudflare/build-output-utils and @cloudflare/runtime-types dependencies that were dropped are no longer imported anywhere in the source.


⚡ Performance: ✅ LGTM

The change only removes code, and nothing in it adds work on the dev or build path.


📝 Documentation: ✅ LGTM

No documentation issues. The feature was experimental, so the decision not to update the public docs is reasonable.


Reviewed commit: 8e584f42

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants