Skip to content

[vite-plugin] Prepare v1 maintenance workspace - #16291

Merged
petebacondarwin merged 7 commits into
vite-plugin-v1from
codex/vite-v1-standalone
Oct 16, 2026
Merged

petebacondarwin merged 7 commits into
vite-plugin-v1from
codex/vite-v1-standalone

Conversation

@petebacondarwin

@petebacondarwin petebacondarwin commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Prepare vite-plugin-v1 to maintain the Vite plugin independently of the public SDK packages on main.

  • Remove public sibling packages, unrelated fixtures, obsolete changesets, and their tooling; no vendor directory remains. Keep the plugin playgrounds, integration fixtures, shared fixture helpers, shared TypeScript and lint configurations, and the private dependency closure (remote-bindings, workers-shared, and mock-npm-registry). Private dependencies remain workspace:*.
  • Pin public SDK dependencies to deployed npm versions and regenerate the lockfile. Resolve Wrangler and Verdaccio executables through installed packages so tests work without their former source directories.
  • Replace the monorepo workflows with plugin checks, unit/fixture tests, Vite 6/7/8 playground coverage, package-manager E2E, preview packages, and changeset releases targeting this branch. Retain the ownership approval/rerun workflows and the existing required CI status names, and restore Bonk reviews for new v1 PRs while skipping changeset releases. Publish only the plugin, using npm’s default latest dist-tag for maintenance releases until v2 goes GA. Keep credentialed E2E behind the existing remote-test gate.
  • Keep the plugin's Vite devDependency on the shared exact-version catalog so compatibility jobs select the same Vite major for the test harness and playgrounds. Assert the expected major in global setup, and retain startup diagnostics for CI timeouts.
  • Restore signed Turbo remote caching for CI, E2E, and playground jobs. Cache keys include the normalized target base branch, OS, Node version, selected Vite major, pre-downgrade plugin build hash, and shared test configuration/helpers. Run lint, types, and formatting through Turbo, and retain node lint-turbo.mjs in pnpm check. Release builds keep their cache controls.
  • Update branch maintenance instructions and remove Dependabot configuration; dependency fixes are backported from individual PRs on main. The plugin's implementation remains unchanged; private support sources stay available for future compatible backports.

Validation:

  • All ten workflow files parse, action pinning passes, and the matrices produce all 16 status names required by the target branch ruleset.
  • pnpm install, pnpm build, and pnpm check passed, including dependency, workflow, lint, type, and format validation.
  • Cache validation passed: changing the base branch, OS, Node, Vite, plugin/private source, or shared test files changes the relevant task hashes. Scoped playground tests executed and then hit the local cache in both modes; all 60 check tasks passed and all 60 were cached on an unchanged rerun.
  • Release build with SOURCEMAPS=false and the package source-map assertions passed.
  • pnpm test:ci passed, including 257 plugin unit tests and the retained private-package suites.
  • Playground dev mode passed: 292 tests plus 8 expected failures; 73 skipped tests.
  • Vite 6 playground dev and build/preview suites passed locally (285 and 295 tests respectively). Vite 7 passed both suites (290 and 316 tests respectively), with the expected version/platform skips.
  • A pnpm package-install smoke test passed in dev and build/preview modes.
  • Playground build/preview mode passed: 317 tests; 56 skipped tests.
  • pnpm test:fixtures passed: 30 dev-registry tests, 5 harness unit tests, and 2 Playwright tests.

Review focus: the package/fixture retention boundary and plugin-only release workflow. Credentialed E2E and actual package publication were not run locally; CI covers the OS and Vite version matrix.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: this changes maintenance infrastructure; branch contributor documentation is updated here.

Note

This contribution was prepared by Codex at the maintainer's request.


Devin Review

@petebacondarwin petebacondarwin added maintenance Maintenance task dependencies Used by dependabot to mark PRs as updates to dependencies. package:vite-plugin Relating to the `@cloudflare/vite-plugin` package labels Oct 15, 2026
@changeset-bot

changeset-bot Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

ðŸĶ‹ Changeset detected

Latest commit: 5822b8d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/vite-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@workers-devprod
workers-devprod requested review from a team and removed request for a team October 15, 2026 15:58
@pkg-pr-new

pkg-pr-new Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
npm i https://pkg.pr.new/@cloudflare/vite-plugin@16291

commit: 5822b8d

@petebacondarwin
petebacondarwin force-pushed the codex/vite-v1-standalone branch from f93dab2 to baf869b Compare October 15, 2026 16:27
@workers-devprod

workers-devprod commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • @cloudflare/cloudchamber
  • @cloudflare/d1
  • @cloudflare/workers-kv
  • @cloudflare/workflows
  • ✅ @cloudflare/wrangler

@petebacondarwin
petebacondarwin added this pull request to stack #16295 October 15, 2026 16:38
Comment thread .github/actions/check-remote-tests/action.yml Outdated
Comment thread .github/dependabot.yml Outdated
Comment thread package.json Outdated
Comment thread package.json Outdated
petebacondarwin and others added 3 commits October 16, 2026 12:18
Co-authored-by: James Opstad <13586373+jamesopstad@users.noreply.github.com>
Co-authored-by: James Opstad <13586373+jamesopstad@users.noreply.github.com>
@jamesopstad

Copy link
Copy Markdown
Contributor

Codeowners bypass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Used by dependabot to mark PRs as updates to dependencies. maintenance Maintenance task package:vite-plugin Relating to the `@cloudflare/vite-plugin` package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants