Repository navigation
chore(vitest): migrate remaining workspace tests to v5 - #16259
Conversation
ðĶ Changeset detectedLatest commit: a6b074a The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
I'm Bonk, and I've done a quick review of your PR. Confirmed PR #16259. Migrates workspace tests and templates to Vitest 5.
|
@cloudflare/autoconfig
@cloudflare/build-output-utils
@cloudflare/codemods
@cloudflare/config
@cloudflare/containers-shared
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-functions
@cloudflare/pages-shared
@cloudflare/runtime-types
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-plugin
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
petebacondarwin
left a comment
There was a problem hiding this comment.
Looks like it needs a rebase and I propose that you split the changeset. Otherwise LGTM
1dfb66a to
61cf517
Compare
|
â Approved â No problems found. The Vitest 5 migration is consistent across manifests, test APIs, snapshot names, templates and changesets, and it changes no production code at runtime. The decision is advisory: this comment never approves, blocks or requests changes on the pull request. â All checks passedð Release: â LGTMRisk: low. Patch changesets cover the wider peer ranges and the template updates. ð Security: â LGTMThis pull request only changes test tooling and dependency versions. It has no security impact. ð AGENTS.md: â LGTMThe update to ð Code Quality: â LGTMChecked the switch from sequential to ⥠Performance: â LGTMThe change does not touch any runtime code path. ð Documentation: â LGTMThe changesets and the package AGENTS.md update match the change. Reviewed commit: |
petebacondarwin
left a comment
There was a problem hiding this comment.
Codeowners bypass
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
@cloudflare/vitest-plugin@1.4.3for four shared packages, preserving the dependency-cycle boundary. Templates require plugin 1.4.3 or newer, so all consumers can use filesystem module caching.pnpm check; 772 shared-package tests and 120 plugin tests pass. The focused local Wrangler dev E2E tests pass in CI mode without credentials.Note
Created with GPT-6 using the Codex desktop harness, under human supervision.