Repository navigation
Stop uppercasing name=, identifier= and sound_href= in strmlabs:// - #1821
Merged
Merged
Conversation
parse_url() upper-cased these values, so the donor name showed up in capitals and a sound_href such as https://example.org/Sounds/Alert.mp3 became HTTPS://EXAMPLE.ORG/SOUNDS/ALERT.MP3, which no longer points to the same file.
Codecov Reportâ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1821 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 246 255 +9
Lines 40326 41325 +999
Branches 6956 7124 +168
==========================================
+ Hits 40326 41325 +999
ð New features to boost your workflow:
|
Owner
|
thank you! Merged! ð |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issue (if applicable): none
NotifyStreamlabs.parse_url()calls.upper()onname,identifierandsound_hrefbefore passing them to the plugin:So the donor name always shows up in capitals, and a
sound_hrefwith mixed case in its path ends up pointing to a different file.image_href, parsed right next to it, is already passed through as-is.The fix drops
.upper()for those three values.callandcurrencykeep it, since they're matched against fixed upper-case values.Checklist
tox -e lintand optionallytox -e format).tox -e qa).Testing
test_plugin_streamlabs_preserves_case, which checks thatnameandidentifierreach the donation payload andsound_hrefreaches the alert payload unchanged. It fails on master.tox -e lintandtox -e qapass.