Repository navigation
Keep from=, flash= and label= in seven:// url() - #1774
Merged
Merged
Conversation
url() built its own parameters and then replaced them with the result of url_parameters(), so the source, flash and label settings were lost whenever the URL was regenerated.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1774 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 246 246
Lines 40326 40339 +13
Branches 6956 6957 +1
=========================================
+ Hits 40326 40339 +13
🚀 New features to boost your workflow:
|
Owner
|
Thank you for all of your PRs ❤️🙏. I'm still going through them. From a glance, they all look great! I'll merge them soon. 🚀🚀 |
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issue (if applicable): none
NotifySeven.url()builds aparamsdict withflash,fromandlabel, and then replaces it with the result ofurl_parameters()instead of extending it:So these settings are lost whenever the URL is regenerated (
Apprise.urls(), saved configs, etc.):The fix uses
params.update(...)like the rest of the plugins. I checked the other plugins that assignparams = self.url_parameters(...)and seven is the only one that had already filledparamsbefore that line.Checklist
tox -e lintand optionallytox -e format).tox -e qa).Testing
Added
test_plugin_seven_url_round_trip, which checks thatfrom,flash,labelandverifyare inurl()and survive reloading the object from it. It fails on master.