Fix environment variables being overwritten when they match on prefix - #4966
Merged
Conversation
Make sure to check for the '=' character to match the whole name.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses incorrect environment variable matching in MirALâs app-launch environment handling, ensuring that updates/unsets only apply to the exact variable name (not variables that merely share a prefix).
Changes:
- Introduces a helper to match environment entries by full variable name by requiring an
=delimiter. - Updates
Environment::setenv()andEnvironment::unsetenv()to use the helper for exact-name matching.
AlanGriffiths
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure to check for the '=' character to match the whole name.