Add tests for IniFile failure modes - #4847
Merged
Merged
Conversation
tarek-y-ismail
force-pushed
the
ini-file-handle-whitespace
branch
from
April 14, 2026 16:04
2fd5a5c to
5158833
Compare
tarek-y-ismail
force-pushed
the
ini-file-failure-tests
branch
from
April 14, 2026 16:05
2c0b064 to
415663e
Compare
This was referenced Apr 15, 2026
tarek-y-ismail
force-pushed
the
ini-file-handle-whitespace
branch
3 times, most recently
from
April 15, 2026 16:22
40d3e3f to
097e8d7
Compare
tarek-y-ismail
force-pushed
the
ini-file-failure-tests
branch
2 times, most recently
from
April 16, 2026 15:17
7e10bce to
58e209b
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds regression tests for miral::live_config::IniFile around invalid/edge-case INI input, covering behavior introduced/clarified by the recent BasicStore extraction and whitespace trimming changes.
Changes:
- Add tests ensuring unparsable scalar values are ignored (handlers not invoked) and unparsable array entries are filtered.
- Add tests for syntax edge cases (non-INI lines, empty keys/values, values containing
=). - Add tests validating whitespace trimming and reload semantics (no array accumulation; latest scalar wins).
tarek-y-ismail
force-pushed
the
ini-file-failure-tests
branch
2 times, most recently
from
April 16, 2026 16:05
b34340e to
1263274
Compare
AlanGriffiths
requested changes
Apr 17, 2026
tarek-y-ismail
force-pushed
the
ini-file-failure-tests
branch
from
April 17, 2026 15:49
1263274 to
e6b7847
Compare
tarek-y-ismail
changed the base branch from
main
to
basic-store-better-handle-unhappy-paths
April 17, 2026 15:51
tarek-y-ismail
force-pushed
the
basic-store-better-handle-unhappy-paths
branch
2 times, most recently
from
April 20, 2026 15:00
63fc895 to
6cda5d0
Compare
Base automatically changed from
basic-store-better-handle-unhappy-paths
to
main
April 20, 2026 16:59
tarek-y-ismail
force-pushed
the
ini-file-failure-tests
branch
from
April 21, 2026 12:17
e6b7847 to
75abd5e
Compare
AlanGriffiths
approved these changes
Apr 21, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Apr 21, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Apr 21, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Apr 21, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Apr 22, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Apr 22, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Apr 22, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Apr 22, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Apr 22, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #4863, #4829, #4846
What's new
IniFile's unhappy cases: invalid syntax, whitespace, etc...How to test
<path/to/build>/miral-test --gtest_filter=LiveConfigIniFile.*Checklist