Fixes TICS violations in wayland_connector.cpp - #4804
Merged
Saviq merged 3 commits intoApr 1, 2026
Merged
Conversation
RAOF
requested changes
Mar 31, 2026
RAOF
left a comment
RAOF
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this!
I think this could be simpler (and avoid const_cast<>) by taking a wl_client const* everywhere instead; client.cpp never needs a non-const wl_client, so we can just store wl_client const* and not need the overrides.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Apr 1, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Apr 1, 2026
Contributor
Author
|
BuildAndTest (lxd:...:spread/ubuntu:asan) status check seems to be failing, does not seem to be related to my changes. |
Contributor
Yeah, seen this one on other PRs too. Sometimes a test "becomes flaky" and we chase down the cause. (Strictly speaking, the test was likely always flaky, but something changed to make it obvious.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4711
What's new?
Resolved TICS violations in mentioned file.
reinterpret_cast->static_casteventfd_t ignored{};WlClient::fromto accept const client.