Repository navigation
Add FreeBSD Platform Detection - #4312
Merged
Merged
Conversation
Marusyk
approved these changes
Jul 29, 2024
devlead
approved these changes
Sep 26, 2024
devlead
left a comment
devlead
left a comment
Member
There was a problem hiding this comment.
LGTM👍 Breaking change so adding this one to 5.0 release, which hopefully will be out shortly after .NET 9 is released.
Member
|
@Thefrank your changes have been merged, thanks for your contribution 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4310
This PR adds FreeBSD as a detected platform to Cake. It also includes a platform test.
As .NET Standard does not support FreeBSD directly, and not to break .NET Standard compatibility, the function
RuntimeInformation.IsOSPlatform(OSPlatform.Create())is used.After building I did find test failures that seem to originate from
VerifyTestsas it does not support FreeBSD either. I will open a PR at that repo to address it. Tests are attached belowEven after this, Cake will not dogfood under FreeBSD as the tool
GitVersionusesLib2GitSharpwhich consumes a NuGet made by https://github.com/libgit2/libgit2sharp.nativebinaries that does not include a FreeBSD library.GitVersionuses Cake to build.Zip'd results using
/logger:htmlfor testsresults.zip