Repository navigation
caddyfile: fix importGraph self-loop and stale-edge bugs - #7971
Merged
Merged
Conversation
- willCycle now reports a cycle when from == to, so addEdge rejects self-loops (a self-importing file was previously accepted). - removeNode now drops the removed node's outgoing edges and any incoming edges pointing at it, keeping the adjacency map consistent. Signed-off-by: Mohammed Al Sahaf <msaa1990@gmail.com>
This was referenced Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
willCyclenow reports a cycle when from == to, soaddEdgerejects self-loops (a self-importing file was previously accepted).removeNodenow drops the removed node's outgoing edges and any incoming edges pointing at it, keeping the adjacency map consistent.Assistance Disclosure
Test was generated by copilot/Claude 4.7; fixed by the same.
Related to #7227