Repository navigation
Conversation
francislavoie
approved these changes
Apr 25, 2026
francislavoie
left a comment
francislavoie
left a comment
Member
There was a problem hiding this comment.
LGTM, needs a rebase to fix go.mod then we can merge.
This was referenced May 11, 2026
social4hyq
pushed a commit
to social4hyq/homebrew-core
that referenced
this pull request
Sep 20, 2026
caddy 2.11.3 Created-by: HarmonybrewBot Commit-by: HarmonybrewBot Merged-by: HarmonybrewBot Description: Created by `brew bump` --- Created with `brew bump-formula-pr`. - [ ] `resource` blocks have been checked for updates. <details> <summary>release notes</summary> <pre>This release improves several aspects of Caddy with minor features, bug fixes, and security patches. Thank you to everyone and their bots who contributed to help make this release the best one yet! **Security patches:** - fastcgi: Carrying over a patch from FrankenPHP for a bug that could allow non-PHP files to be executed; collaborated on by @dunglas, @KC1zs4, and @chenjj. - vars: A more thorough fix for GHSA-m2w3-8f23-hxxf, collaborated by @everping and @vnxme. - admin: Array index normalization to prevent remote admin socket auth bypass, by @Amemoyoi and bot. - admin: More rigorous path prefix matching to prevent remote admin socket auth bypass, by @Amemoyoi and bot. We've also merged a couple PRs that fix upstream security bugs in other projects like quic-go and CertMagic. Thank you to @marten-seemann for maintaining quic-go so diligently! ## What's Changed * caddyhttp: Sync placeholder expansion in `vars` and `vars_regexp` by @vnxme in caddyserver/caddy#7573 * caddytls: Avoid ACME fallback for implicit Tailscale *.ts.net policies by @steadytao in caddyserver/caddy#7577 * chore: Resolve recent CI failures by @mholt in caddyserver/caddy#7593 * caddytls: Consolidate empty APs more smartly by @mholt in caddyserver/caddy#7567 * rewrite: skip query rename when source key is absent by @steadytao in caddyserver/caddy#7599 * root: introduce down-propagating Helper.BlockState for other directives/plugins to use by @henderkes in caddyserver/caddy#7594 * http: make zstd checksum configurable by @ottenhoff in caddyserver/caddy#7586 * notify: Always send "READY=1" even after an error by @francislavoie in caddyserver/caddy#7597 * reverseproxy: Fix check for `header_up Host {upstream_hostport}` redundancy by @yubiuser in caddyserver/caddy#7564 * caddytls: Expand placeholders in dns_challenge override_domain tls parameter by @pberkel in caddyserver/caddy#7609 * tls: add system and combined CA pool modules by @HarshPatel5940 in caddyserver/caddy#7406 * vars: Don't expand placeholders in values by @vnxme in caddyserver/caddy#7629 * build(deps): bump go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp from 1.42.0 to 1.43.0 by @dependabot[bot] in caddyserver/caddy#7637 * build(deps): bump the all-updates group across 1 directory with 11 updates by @dependabot[bot] in caddyserver/caddy#7641 * reverseproxy: make stream copy buffer size configurable by @steadytao in caddyserver/caddy#7627 * vars: Add matcher placeholder handling tests by @steadytao in caddyserver/caddy#7640 * build(deps): bump github.com/go-jose/go-jose/v4 from 4.1.3 to 4.1.4 by @dependabot[bot] in caddyserver/caddy#7621 * logging: Add journald encoder wrapper by @steadytao in caddyserver/caddy#7623 * caddyfile: Improve import/global options UX for imports before global options by @steadytao in caddyserver/caddy#7642 * chore: replace `interface{}` with `any` for modernization by @tsinglua in caddyserver/caddy#7571 * chore: bump timberjack to v1.4.1 by @DeRuina in caddyserver/caddy#7618 * logging: Preserve ts for journald-wrapped JSON logs by @steadytao in caddyserver/caddy#7644 * fileserver: show symlink targets verbatim (#7476) by @maxtruxa in caddyserver/caddy#7579 * fix(caddyfile): {block} in snippet by @prettysunflower in caddyserver/caddy#7558 * caddyhttp: Document missing placeholders for escaped URI and prefixed query by @steffenbusch in caddyserver/caddy#7659 * chore: add `AGENTS.md` by @mohammed90 in caddyserver/caddy#7652 * build(deps): bump github.com/jackc/pgx/v5 from 5.8.0 to 5.9.0 by @dependabot[bot] in caddyserver/caddy#7655 * admin: Redact sensitive request headers in API logs by @steadytao in caddyserver/caddy#7578 * reverseproxy: add `lb_retry_match` condition on response status by @seroperson in caddyserver/caddy#7569 * caddyhttp: prefer port 443 in auto-HTTPS and add tests by @mholt in caddyserver/caddy#7666 * fix: Propagate ECH keys to the QUIC listener by @steadytao in caddyserver/caddy#7670 * chore: Use atomics where appropriate by @francislavoie in caddyserver/caddy#7648 * metrics: Implement pushing via OLTP by @dunglas in caddyserver/caddy#7664 * logging: Add regression coverage for rotated file mode by @steadytao in caddyserver/caddy#7620 * httpcaddyfile: Inherit global ACME issuer settings in tls shortcuts by @steadytao in caddyserver/caddy#7617 * build(deps): bump github.com/jackc/pgx/v5 from 5.9.0 to 5.9.2 by @dependabot[bot] in caddyserver/caddy#7668 * admin: require path segment boundary in remote access control by @Amemoyoi in caddyserver/caddy#7673 * reverseproxy: Add ability to clear dynamic upstreams cache during retries by @mholt in caddyserver/caddy#7662 * listeners: clean up stale Unix socket files on Windows by @mfrischknecht in caddyserver/caddy#7676 * admin: reject non-canonical config array indices by @Amemoyoi in caddyserver/caddy#7592 * caddytls: Expand ACME credentials by @tribut in caddyserver/caddy#7554 * caddyauth: set user placeholders before auth rejection by @cyphercodes in caddyserver/caddy#7685 * caddyauth: revert user placeholders on auth rejection by @steadytao in caddyserver/caddy#7688 * chore: Fix golangci-lint 2.12.1 findings by @steadytao in caddyserver/caddy#7690 * httpcaddyfile: accept duration strings for log sampling interval by @tomholford in caddyserver/caddy#7694 * tls: Add alpn to managed HTTPS records by @steadytao in caddyserver/caddy#7653 * caddytls: avoid duplicate automation for wildcard-covered hosts by @Rijul-A in caddyserver/caddy#7697 * docs: add documentation for fileExists and fileStat template functions by @steffenbusch in caddyserver/caddy#7700 * rewrite: escape file matcher paths before rewriting by @cyphercodes in caddyserver/caddy#7683 * metrics: Add nil check for metricsHandler in AdminMetrics.serveHTTP by @Br1an67 in caddyserver/caddy#7553 ## New Contributors * @steadytao made their first contribution in caddyserver/caddy#7577 * @henderkes made their first contribution in caddyserver/caddy#7594 * @yubiuser made their first contribution in caddyserver/caddy#7564 * @pberkel made their first contribution in caddyserver/caddy#7609 * @HarshPatel5940 made their first contribution in caddyserver/caddy#7406 * @tsinglua made their first contribution in caddyserver/caddy#7571 * @maxtruxa made their first contribution in caddyserver/caddy#7579 * @seroperson made their first contribution in caddyserver/caddy#7569 * @Amemoyoi made their first contribution in caddyserver/caddy#7673 * @mfrischknecht made their first contribution in caddyserver/caddy#7676 * @tribut made their first contribution in caddyserver/caddy#7554 * @cyphercodes made their first contribution in caddyserver/caddy#7685 * @tomholford made their first contribution in caddyserver/caddy#7694 * @Rijul-A made their first contribution in caddyserver/caddy#7697 * @Br1an67 made their first contribution in caddyserver/caddy#7553 **Full Changelog**: https://github.com/caddyserver/caddy/compare/v2.11.2...v2.11.3</pre> <p>View the full release notes at <a href="https://github.com/caddyserver/caddy/releases/tag/v2.11.3">https://github.com/caddyserver/caddy/releases/tag/v2.11.3</a>.</p> </details> <hr> See merge request: Harmonybrew/homebrew-core!842
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Caddy-side regression coverage for the log rotation mode issue addressed by the timberjack bump in #7618.
Why
Issue #7613 reported that after log rotation, the new active log file could lose permissions configured via
modebecause the process umask still masked bits during rotation-time file creation.The behavioral fix belongs in
github.com/DeRuina/timberjackand was brought into Caddy by #7618, which bumps timberjack tov1.4.1.This PR does not change Caddy runtime behavior. It adds regression coverage to ensure Caddyâs integration continues to preserve the configured file mode across rotation under a nonzero umask.
What this tests
The new test exercises the user-facing behavior from #7613:
umaskset to002206600660Related
Assistance Disclosure
No AI was used.