Repository navigation
reverseproxy: do not disable keepalive if proxy protocol is used - #7300
Merged
Merged
Conversation
WeidiDeng
force-pushed
the
pp-w-keepalive
branch
from
October 12, 2025 00:36
ae364b0 to
a64931b
Compare
francislavoie
approved these changes
Oct 16, 2025
francislavoie
left a comment
Member
There was a problem hiding this comment.
Makes sense to me! Nice little improvement to an edgecase.
âĶ the upstream network is unix
francislavoie
force-pushed
the
pp-w-keepalive
branch
from
October 21, 2025 05:03
a64931b to
637ec01
Compare
francislavoie
enabled auto-merge (squash)
October 21, 2025 05:04
4 tasks
mholt
pushed a commit
that referenced
this pull request
Feb 6, 2026
This was referenced May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If proxy protocol is enabled, keepalive was disabled because there was no known way to differentiate requests to the same upstream from different clients.
But caddy actually updates the url in the requests to point to the upstream, this url is then used to dial to the upstream unless if a proxy is used for this request, in which case the proxy url is used for the dial.
We can update the url to add unique identifiers to create a mapping between the client address and the upstream address so that connections can be kept alive and requests from different clients to the same upstream won't interfere with each other.
Using the following caddyfile:
And curl command will output the same response;
Assistance Disclosure
No AI was used.