Restore gesture requirement for async clipboard write access

Chromium 66+ implements Asynchronous Clipboard API. Chromium, in contrast to Safari and Firefox, allow a website to write to the user's clipboard using navigator.clipboard.writeText()/write() without a user gesture (only criteria is that the tab should be active).

We should require a user gesture (click, touch events) to enable use of navigator.clipboard.writeText() and navigator.clipboard.write(). Else, promise should reject.

Demo website that attempts to write to the user's clipboard: https://shivankaul.com/brave/clipboard-paste.html (if you get a success message, try to paste)

mozilla/standards-positions#89

Could this be re-evaluated?
Personally i really don't like this clipboard feature at all and want it gone in it's entirety.. That's probably not going to happen so please put it behind a permission request at the very least.

Am here to voice concern over this, its incredibly invasive and I would like to see it removed entirely from the Brave engine.

When it's time to try the fix, we'll need to go shields down to test the test page when fixing as EasyList is blocking what is required to test the gesture

The above will require 1.43.91 or higher for 1.43.x verification 👍

Verified with

Brave | 1.43.91 Chromium: 105.0.5195.102 (Official Build) (x86_64)
-- | --
Revision | 4c16f5ffcc2da70ee2600d5db77bed423ac03a5a-refs/branch-heads/5195_55@{#4}
OS | macOS Version 12.5.1 (Build 21G83)

Reproduced the issue using 1.43.88 and STR from brave/brave-core#14901 (comment).
Checked with shields up and shields down as per #16890 (comment).

1.43.88 Shields Up	1.43.88 Shields Down

Verified issue does not occur with 1.43.91. Checked with shields up and shields down.
When pasting in a new tab, my clipboard was no overwritten, it was the same text I had prior to visiting the page.

1.43.91 Shields Up	1.43.91 Shields Down

Note - Per brave/brave-core#14901 (comment), if you see "NotAllowedError" message this is ok as well. I did see this when changing shield settings.

Verification PASSED using

Brave | 1.43.91 Chromium: 105.0.5195.102 (Official Build) (64-bit)
-- | --
Revision | 4c16f5ffcc2da70ee2600d5db77bed423ac03a5a-refs/branch-heads/5195_55@{#4}
OS | Windows 11 Version 21H2 (Build 22000.856)

Reproduced the issue using 1.43.89 and STR from brave/brave-core#14901 (comment).
Checked with shields up and shields down as per #16890 (comment).

1.43.89 Shields Up	1.43.89 Shields Down

Verified issue does not occur with 1.43.91. Checked with shields up and shields down.
When pasting in a new tab, my clipboard was not overwritten, it was the same text I had prior to visiting the page.

1.43.91 Shields Up	1.43.91 Shields Down

Note - Per brave/brave-core#14901 (comment), if you see "NotAllowedError" message this is ok as well. I did see this when changing shield settings. (Refreshed the page and the error message was dismissed)

Verification passed on

Brave	1.43.92 Chromium: 105.0.5195.102 (Official Build) (64-bit)
Revision	4c16f5ffcc2da70ee2600d5db77bed423ac03a5a-refs/branch-heads/5195_55@{#4}
OS	Ubuntu 18.04 LTS

Verified brave/brave-core#14901

Reproduced in 1.43.88
Verified in 1.43.92

Details

shields on ![image](https://user-images.githubusercontent.com/34715963/189639263-4d473d42-2d7a-46cf-a314-cb040c9785a0.png)

shields down

Verification passed on Oppo Reno 5 with Android 12 running 1.43.92 x64 build

Reproduced the issue on 1.43.88
Verified with both Shields Up/Down

1.43.88	1.43.92

Verification passed on Samsung Tab A with Android 10 running 1.43.92 x64 build

Reproduced the issue on 1.43.88
Verified with both Shields Up/Down

1.43.88	1.43.92

Navigation Menu

Repository navigation

Restore gesture requirement for async clipboard write access #16890

8 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Restore gesture requirement for async clipboard write access #16890

Description

Activity

ShivanKaul commented on Oct 1, 2021

markg85 commented on Aug 28, 2022

androolloyd commented on Aug 30, 2022

bsclifton commented on Aug 30, 2022

8 remaining items

kjozwiak commented on Sep 7, 2022

LaurenWags commented on Sep 8, 2022

MadhaviSeelam commented on Sep 8, 2022

btlechowski commented on Sep 12, 2022

srirambv commented on Sep 13, 2022

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions