Skip to content

api, metrics: add 'type' to forward dests, deprecate 'protocol' - #6170

Merged
aler9 merged 1 commit into
mainfrom
feature/0-forward-type
Sep 3, 2026
Merged

aler9 merged 1 commit into
mainfrom
feature/0-forward-type

Conversation

@aler9

@aler9 aler9 commented Sep 2, 2026

Copy link
Copy Markdown
Member

'type' is aligned with the terminology used in the rest of the server.

@codecov

codecov Bot commented Sep 2, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.66667% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.35%. Comparing base (dac59ec) to head (47c1207).

Files with missing lines Patch % Lines
internal/forward/dest_handler.go 83.72% 7 Missing ⚠️
internal/apidocsgen/structs.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6170      +/-   ##
==========================================
+ Coverage   64.33%   64.35%   +0.02%     
==========================================
  Files         272      272              
  Lines       23371    23391      +20     
==========================================
+ Hits        15035    15053      +18     
- Misses       7100     7101       +1     
- Partials     1236     1237       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aler9 aler9 changed the title api, metrics: add 'type' to forward dests, deprecated 'protocol' api, metrics: add 'type' to forward dests, deprecate 'protocol' Sep 2, 2026
@aler9
aler9 force-pushed the feature/0-forward-type branch 4 times, most recently from 15509e9 to e005f31 Compare September 3, 2026 12:08
@aler9
aler9 enabled auto-merge (squash) September 3, 2026 12:09
@aler9
aler9 force-pushed the feature/0-forward-type branch 2 times, most recently from 7ea3744 to 0beed84 Compare September 3, 2026 14:32
'type' is aligned with the terminology used in the rest of the server.
@aler9
aler9 force-pushed the feature/0-forward-type branch from 0beed84 to 47c1207 Compare September 3, 2026 14:34
@aler9
aler9 merged commit f63e250 into main Sep 3, 2026
17 checks passed
@aler9
aler9 deleted the feature/0-forward-type branch September 3, 2026 14:40
@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

This issue is mentioned in release v1.21.0 🚀
Check out the entire changelog by clicking here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant