Skip to content

recorder: reset when absolute time drifts from stream time (#4778) - #5239

Merged
aler9 merged 1 commit into
mainfrom
feature/drift-detector
Dec 2, 2025
Merged

aler9 merged 1 commit into
mainfrom
feature/drift-detector

Conversation

@aler9

@aler9 aler9 commented Dec 2, 2025

Copy link
Copy Markdown
Member

Fixes #4778

@aler9
aler9 force-pushed the feature/drift-detector branch 2 times, most recently from d72754c to c2b3706 Compare December 2, 2025 15:09
@aler9 aler9 changed the title recorder: reset in case of time driftings (#4778) recorder: reset when absolute time drifts from stream time (#4778) Dec 2, 2025
@codecov

codecov Bot commented Dec 2, 2025 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.93548% with 41 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.73%. Comparing base (9c59304) to head (7c9961a).

Files with missing lines Patch % Lines
internal/recorder/format_mpegts.go 38.46% 24 Missing ⚠️
internal/recorder/format_fmp4.go 52.63% 9 Missing ⚠️
internal/recorder/format_mpegts_track.go 87.75% 3 Missing and 3 partials ⚠️
internal/recorder/format_fmp4_track.go 85.71% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5239      +/-   ##
==========================================
+ Coverage   55.70%   55.73%   +0.02%     
==========================================
  Files         186      187       +1     
  Lines       15567    15587      +20     
==========================================
+ Hits         8672     8687      +15     
- Misses       6164     6167       +3     
- Partials      731      733       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

the server now detects when system time changes too much and restart
recording when that happens.
@aler9
aler9 force-pushed the feature/drift-detector branch from 7c9961a to 98580ac Compare December 2, 2025 17:05
@aler9
aler9 merged commit fb9027a into main Dec 2, 2025
9 checks passed
@aler9
aler9 deleted the feature/drift-detector branch December 2, 2025 17:10
@github-actions

github-actions Bot commented Dec 7, 2025

Copy link
Copy Markdown
Contributor

This issue is mentioned in release v1.15.5 🚀
Check out the entire changelog by clicking here

@bluenviron bluenviron locked and limited conversation to collaborators Jun 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feat: spawn new recording file if system clock drifted significantly 🕰️

1 participant