Repository navigation
drop standalone H264/H265 trailing SEIs - #1184
Merged
Merged
Conversation
aler9
force-pushed
the
fix/standalone-sei
branch
3 times, most recently
from
October 1, 2026 15:17
ad82218 to
7af6f83
Compare
aler9
added a commit
to bluenviron/mediacommon
that referenced
this pull request
Oct 1, 2026
supporting standalone SEI units should not be necessary anymore since these are filtered out at the root (bluenviron/gortsplib#1184). In case of any issue that should arise after this change, open a bug report and we'll adjust things accordingly.
bluenviron/mediamtx#3614 bluenviron/mediacommon#142 bluenviron/mediamtx#6257 bluenviron/mediacommon#382 H264/H265 access units containing a single SEI only, trailing other units, generated by some TP-Link/Tapo cameras, are non-standard and cause several issues in downstream components, including the DTS extractor and the recorder. Previously, the H265 DTS extractor was adjusted to support such units (#142) but the problem represented itself with H265. Filter these units out at the root.
aler9
force-pushed
the
fix/standalone-sei
branch
from
October 1, 2026 15:25
7af6f83 to
6e61864
Compare
Codecov Reportâ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1184 +/- ##
==========================================
+ Coverage 87.19% 87.23% +0.03%
==========================================
Files 133 133
Lines 10632 10656 +24
==========================================
+ Hits 9271 9296 +25
+ Misses 1361 1360 -1 â View full report in Codecov by Harness. ð New features to boost your workflow:
|
aler9
added a commit
to bluenviron/mediacommon
that referenced
this pull request
Oct 1, 2026
supporting standalone SEI units should not be necessary anymore since these are filtered out at the root (bluenviron/gortsplib#1184). In case of any issue that should arise after this change, open a bug report and we'll adjust things accordingly.
aler9
enabled auto-merge (squash)
October 1, 2026 15:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bluenviron/mediamtx#3614
bluenviron/mediacommon#142
bluenviron/mediamtx#6257
bluenviron/mediacommon#382
H264/H265 access units containing a single SEI only, trailing other units, generated by some TP-Link/Tapo cameras, are non-standard and cause several issues in downstream components, including the DTS extractor and the recorder. Previously, the H265 DTS extractor was adjusted to support such units (#142) but the problem represented itself with H265. Filter these units out at the root.