Repository navigation
fix(lint/js): mark no-this-in-static fixes unsafe - #11456
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: abe8603 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
✅ Organic activityNo automation signals detected in the analyzed events. This is an automated analysis by AgentScan |
github-actions
Bot
added
A-Linter
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. WalkthroughThe Merge Risk: ⚪ Minimal · up to This PR only marks the lint rule's automatic fixes as unsafe and updates the related snapshot and changeset; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
Merging this PR will not alter performance
Comparing 
Footnotes
|
ematipico
approved these changes
Aug 21, 2026
Merged
OIRNOIR
pushed a commit
to OIRNOIR/YouTube-Helper-Client
that referenced
this pull request
Sep 4, 2026
This PR contains the following updates: | Package | Type | Update | Change | Pending | |---|---|---|---|---| | [@biomejs/biome](https://biomejs.dev) ([source](https://github.com/biomejs/biome/tree/HEAD/packages/@biomejs/biome)) | imports | patch | [`2.5.10` -> `2.5.11`](https://renovatebot.com/diffs/npm/@biomejs%2fbiome/2.5.10/2.5.11) | `2.5.12` | --- ### Release Notes <details> <summary>biomejs/biome (@​biomejs/biome)</summary> ### [`v2.5.11`](https://github.com/biomejs/biome/blob/HEAD/packages/@biomejs/biome/CHANGELOG.md#2511) [Compare Source](https://github.com/biomejs/biome/compare/@biomejs/biome@2.5.10...@biomejs/biome@2.5.11) ##### Patch Changes - [#​11499](biomejs/biome#11499) [`9743d0c`](biomejs/biome@9743d0c) Thanks [@​scs0209](https://github.com/scs0209)! - Fixed [#​11496](biomejs/biome#11496): [`useValidAnchor`](https://biomejs.dev/linter/rules/use-valid-anchor/) now treats Astro JSX shorthand attributes like `<a {href}>` as a valid `href`. - [#​11437](biomejs/biome#11437) [`88f805e`](biomejs/biome@88f805e) Thanks [@​Princesseuh](https://github.com/Princesseuh)! - Fixed [#​9944](biomejs/biome#9944): adjacent elements inside an Astro expression now parse as an implicit fragment instead of raising an error. ```astro {options.map(() => <div /> <div /> )} ``` - [#​11437](biomejs/biome#11437) [`88f805e`](biomejs/biome@88f805e) Thanks [@​Princesseuh](https://github.com/Princesseuh)! - Fixed Astro templates rejecting unclosed HTML void elements, such as `{cond && <br>}`. - [#​11507](biomejs/biome#11507) [`e2fc036`](biomejs/biome@e2fc036) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​11157](biomejs/biome#11157): [`noUnusedVariables`](https://biomejs.dev/linter/rules/no-unused-variables/) no longer reports Vue `<script setup>` bindings used by CSS `v-bind()` as unused. - [#​11398](biomejs/biome#11398) [`afc4615`](biomejs/biome@afc4615) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​11389](biomejs/biome#11389): Files passed through `--stdin-file-path` now use full HTML support for Astro, Svelte, and Vue when it is enabled. - [#​11526](biomejs/biome#11526) [`372cd68`](biomejs/biome@372cd68) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [`noVueRefAsOperand`](https://biomejs.dev/linter/rules/no-vue-ref-as-operand/) to track Vue refs through declaration aliases and `toRefs()` properties, and to recognize `useTemplateRef()` results. The rule no longer reports false positives such as plain ref transfers, plain `toRefs()` property access, `defineModel()` modifiers, or the supported `.effect` member as operands. The refactor enabling these fixes also improves the performance of the rule. - [#​11458](biomejs/biome#11458) [`a7cd286`](biomejs/biome@a7cd286) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​11436](biomejs/biome#11436): GritQL snippets such as `export { $specifiers } from $source` now match named re-exports with aliases, inline `type` modifiers, and multiple specifiers. - [#​11515](biomejs/biome#11515) [`382b15d`](biomejs/biome@382b15d) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​11390](biomejs/biome#11390), where `noFloatingPromises` performed expensive full type inference for calls to non-Promise methods declared on third-party TypeScript classes. The rule now classifies those calls using targeted type information. - [#​11516](biomejs/biome#11516) [`6f40e82`](biomejs/biome@6f40e82) Thanks [@​levrik](https://github.com/levrik)! - Fixed [`noVueRefAsOperand`](https://biomejs.dev/linter/rules/no-vue-ref-as-operand/) so it no longer reports a callback parameter (e.g. from `.find()`, `.map()`) as an unwrapped ref value just because it's nested inside a `ref()`, `computed()`, or similar call. ```js const result = computed(() => list.find((item) => item.label === "a")); ``` Previously, `item` here was incorrectly treated as a ref value because the rule attributed it to the outer `computed()` call. - [#​11495](biomejs/biome#11495) [`496268d`](biomejs/biome@496268d) Thanks [@​Netail](https://github.com/Netail)! - Fixed [`useGraphqlNamingConvention`](https://biomejs.dev/linter/rules/use-graphql-naming-convention/) so it no longer reports GraphQL enum value definitions with comments & descriptions and now displays a more accurate diagnostic range. - [#​11407](biomejs/biome#11407) [`6ef52b0`](biomejs/biome@6ef52b0) Thanks [@​1678092075](https://github.com/1678092075)! - Fixed [#​11214](biomejs/biome#11214): [`noUnusedVariables`](https://biomejs.dev/linter/rules/no-unused-variables/) no longer reports type parameters declared by non-default function overload signatures that have an implementation. - [#​11322](biomejs/biome#11322) [`5c353e6`](biomejs/biome@5c353e6) Thanks [@​jp-knj](https://github.com/jp-knj)! - Added a new nursery rule `noAstroSetHtmlDirective`, which disallows Astro's `set:html` directive because untrusted content can introduce cross-site scripting vulnerabilities. For example, the following snippet triggers the rule: ```astro <div set:html={content} /> ``` - [#​11462](biomejs/biome#11462) [`18883b7`](biomejs/biome@18883b7) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​10776](biomejs/biome#10776): [`useVueHyphenatedAttributes`](https://biomejs.dev/linter/rules/use-vue-hyphenated-attributes/) no longer reports lowercase attribute names containing punctuation, such as `pt:header:data-test-id` and `some_attr`. - [#​11476](biomejs/biome#11476) [`3270ca4`](biomejs/biome@3270ca4) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​10330](biomejs/biome#10330): Vue interpolation delimiters now stay attached to whitespace-sensitive element boundaries and adjacent inline siblings, wrapping their expression when needed to fit the configured line width. Interpolations followed by text now also converge after one formatting pass. ```diff -<v-btn v-if="store.state.user" variant="text" to="/my-rooms" - >{{ $t("nav.my-rooms") }}</v-btn -> +<v-btn v-if="store.state.user" variant="text" to="/my-rooms">{{ + $t("nav.my-rooms") +}}</v-btn> ``` - [#​11191](biomejs/biome#11191) [`3e5367f`](biomejs/biome@3e5367f) Thanks [@​ematipico](https://github.com/ematipico)! - Added the nursery rule [`noUndeclaredCustomProperties`](https://biomejs.dev/linter/rules/no-undeclared-custom-properties/), which reports references to custom properties that are not defined in available CSS, static HTML-like `style` attributes, or JSX string `style` attributes. For example, the following snippet triggers the rule: ```css a { color: var(--undefined-color); } ``` - [#​11435](biomejs/biome#11435) [`7754894`](biomejs/biome@7754894) Thanks [@​levrik](https://github.com/levrik)! - Fixed: Variables and imports used as custom Vue directives are no longer reported as unused. For example: ```vue <script setup> const vHighlight = { mounted: (element) => { element.style.color = "red"; }, }; </script> <template> <p v-highlight>Hello</p> </template> ``` - [#​11501](biomejs/biome#11501) [`e6acded`](biomejs/biome@e6acded) Thanks [@​aminya](https://github.com/aminya)! - Improved the performance of [`useArraySortCompare`](https://biomejs.dev/linter/rules/use-array-sort-compare/) by skipping type inference for calls to unrelated methods. - [#​11467](biomejs/biome#11467) [`66b282c`](biomejs/biome@66b282c) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​11464](biomejs/biome#11464): Biome now parses parenthesized object literals returned from arrow functions when they contain a conditional expression and a nested arrow function. - [#​11456](biomejs/biome#11456) [`db9aa2a`](biomejs/biome@db9aa2a) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​10278](biomejs/biome#10278): Marked the fix for [`noThisInStatic`](https://biomejs.dev/linter/rules/no-this-in-static/) as unsafe by default. - [#​11502](biomejs/biome#11502) [`652aedb`](biomejs/biome@652aedb) Thanks [@​levrik](https://github.com/levrik)! - `noGlobalAssign` no longer reports assignments to a Vue `<script setup>` binding from a template expression, when the binding's name happens to match a built-in global (e.g. `open`, `parent`, `top`). For example, this no longer triggers a diagnostic: ```vue <script setup> const open = defineModel(); </script> <template> <button @click="open = !open">Toggle</button> </template> ``` </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC41Ny4zIiwidXBkYXRlZEluVmVyIjoiNDQuNTcuMyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Reviewed-on: https://git.oirnoir.dev/OIRNOIR/YouTube-Helper-Client/pulls/20
OIRNOIR
pushed a commit
to OIRNOIR/YouTube-Helper-Server
that referenced
this pull request
Sep 4, 2026
This PR contains the following updates: | Package | Type | Update | Change | Pending | |---|---|---|---|---| | [@biomejs/biome](https://biomejs.dev) ([source](https://github.com/biomejs/biome/tree/HEAD/packages/@biomejs/biome)) | imports | patch | [`2.5.10` -> `2.5.11`](https://renovatebot.com/diffs/npm/@biomejs%2fbiome/2.5.10/2.5.11) | `2.5.12` | --- ### Release Notes <details> <summary>biomejs/biome (@​biomejs/biome)</summary> ### [`v2.5.11`](https://github.com/biomejs/biome/blob/HEAD/packages/@biomejs/biome/CHANGELOG.md#2511) [Compare Source](https://github.com/biomejs/biome/compare/@biomejs/biome@2.5.10...@biomejs/biome@2.5.11) ##### Patch Changes - [#​11499](biomejs/biome#11499) [`9743d0c`](biomejs/biome@9743d0c) Thanks [@​scs0209](https://github.com/scs0209)! - Fixed [#​11496](biomejs/biome#11496): [`useValidAnchor`](https://biomejs.dev/linter/rules/use-valid-anchor/) now treats Astro JSX shorthand attributes like `<a {href}>` as a valid `href`. - [#​11437](biomejs/biome#11437) [`88f805e`](biomejs/biome@88f805e) Thanks [@​Princesseuh](https://github.com/Princesseuh)! - Fixed [#​9944](biomejs/biome#9944): adjacent elements inside an Astro expression now parse as an implicit fragment instead of raising an error. ```astro {options.map(() => <div /> <div /> )} ``` - [#​11437](biomejs/biome#11437) [`88f805e`](biomejs/biome@88f805e) Thanks [@​Princesseuh](https://github.com/Princesseuh)! - Fixed Astro templates rejecting unclosed HTML void elements, such as `{cond && <br>}`. - [#​11507](biomejs/biome#11507) [`e2fc036`](biomejs/biome@e2fc036) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​11157](biomejs/biome#11157): [`noUnusedVariables`](https://biomejs.dev/linter/rules/no-unused-variables/) no longer reports Vue `<script setup>` bindings used by CSS `v-bind()` as unused. - [#​11398](biomejs/biome#11398) [`afc4615`](biomejs/biome@afc4615) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​11389](biomejs/biome#11389): Files passed through `--stdin-file-path` now use full HTML support for Astro, Svelte, and Vue when it is enabled. - [#​11526](biomejs/biome#11526) [`372cd68`](biomejs/biome@372cd68) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [`noVueRefAsOperand`](https://biomejs.dev/linter/rules/no-vue-ref-as-operand/) to track Vue refs through declaration aliases and `toRefs()` properties, and to recognize `useTemplateRef()` results. The rule no longer reports false positives such as plain ref transfers, plain `toRefs()` property access, `defineModel()` modifiers, or the supported `.effect` member as operands. The refactor enabling these fixes also improves the performance of the rule. - [#​11458](biomejs/biome#11458) [`a7cd286`](biomejs/biome@a7cd286) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​11436](biomejs/biome#11436): GritQL snippets such as `export { $specifiers } from $source` now match named re-exports with aliases, inline `type` modifiers, and multiple specifiers. - [#​11515](biomejs/biome#11515) [`382b15d`](biomejs/biome@382b15d) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​11390](biomejs/biome#11390), where `noFloatingPromises` performed expensive full type inference for calls to non-Promise methods declared on third-party TypeScript classes. The rule now classifies those calls using targeted type information. - [#​11516](biomejs/biome#11516) [`6f40e82`](biomejs/biome@6f40e82) Thanks [@​levrik](https://github.com/levrik)! - Fixed [`noVueRefAsOperand`](https://biomejs.dev/linter/rules/no-vue-ref-as-operand/) so it no longer reports a callback parameter (e.g. from `.find()`, `.map()`) as an unwrapped ref value just because it's nested inside a `ref()`, `computed()`, or similar call. ```js const result = computed(() => list.find((item) => item.label === "a")); ``` Previously, `item` here was incorrectly treated as a ref value because the rule attributed it to the outer `computed()` call. - [#​11495](biomejs/biome#11495) [`496268d`](biomejs/biome@496268d) Thanks [@​Netail](https://github.com/Netail)! - Fixed [`useGraphqlNamingConvention`](https://biomejs.dev/linter/rules/use-graphql-naming-convention/) so it no longer reports GraphQL enum value definitions with comments & descriptions and now displays a more accurate diagnostic range. - [#​11407](biomejs/biome#11407) [`6ef52b0`](biomejs/biome@6ef52b0) Thanks [@​1678092075](https://github.com/1678092075)! - Fixed [#​11214](biomejs/biome#11214): [`noUnusedVariables`](https://biomejs.dev/linter/rules/no-unused-variables/) no longer reports type parameters declared by non-default function overload signatures that have an implementation. - [#​11322](biomejs/biome#11322) [`5c353e6`](biomejs/biome@5c353e6) Thanks [@​jp-knj](https://github.com/jp-knj)! - Added a new nursery rule `noAstroSetHtmlDirective`, which disallows Astro's `set:html` directive because untrusted content can introduce cross-site scripting vulnerabilities. For example, the following snippet triggers the rule: ```astro <div set:html={content} /> ``` - [#​11462](biomejs/biome#11462) [`18883b7`](biomejs/biome@18883b7) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​10776](biomejs/biome#10776): [`useVueHyphenatedAttributes`](https://biomejs.dev/linter/rules/use-vue-hyphenated-attributes/) no longer reports lowercase attribute names containing punctuation, such as `pt:header:data-test-id` and `some_attr`. - [#​11476](biomejs/biome#11476) [`3270ca4`](biomejs/biome@3270ca4) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​10330](biomejs/biome#10330): Vue interpolation delimiters now stay attached to whitespace-sensitive element boundaries and adjacent inline siblings, wrapping their expression when needed to fit the configured line width. Interpolations followed by text now also converge after one formatting pass. ```diff -<v-btn v-if="store.state.user" variant="text" to="/my-rooms" - >{{ $t("nav.my-rooms") }}</v-btn -> +<v-btn v-if="store.state.user" variant="text" to="/my-rooms">{{ + $t("nav.my-rooms") +}}</v-btn> ``` - [#​11191](biomejs/biome#11191) [`3e5367f`](biomejs/biome@3e5367f) Thanks [@​ematipico](https://github.com/ematipico)! - Added the nursery rule [`noUndeclaredCustomProperties`](https://biomejs.dev/linter/rules/no-undeclared-custom-properties/), which reports references to custom properties that are not defined in available CSS, static HTML-like `style` attributes, or JSX string `style` attributes. For example, the following snippet triggers the rule: ```css a { color: var(--undefined-color); } ``` - [#​11435](biomejs/biome#11435) [`7754894`](biomejs/biome@7754894) Thanks [@​levrik](https://github.com/levrik)! - Fixed: Variables and imports used as custom Vue directives are no longer reported as unused. For example: ```vue <script setup> const vHighlight = { mounted: (element) => { element.style.color = "red"; }, }; </script> <template> <p v-highlight>Hello</p> </template> ``` - [#​11501](biomejs/biome#11501) [`e6acded`](biomejs/biome@e6acded) Thanks [@​aminya](https://github.com/aminya)! - Improved the performance of [`useArraySortCompare`](https://biomejs.dev/linter/rules/use-array-sort-compare/) by skipping type inference for calls to unrelated methods. - [#​11467](biomejs/biome#11467) [`66b282c`](biomejs/biome@66b282c) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​11464](biomejs/biome#11464): Biome now parses parenthesized object literals returned from arrow functions when they contain a conditional expression and a nested arrow function. - [#​11456](biomejs/biome#11456) [`db9aa2a`](biomejs/biome@db9aa2a) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​10278](biomejs/biome#10278): Marked the fix for [`noThisInStatic`](https://biomejs.dev/linter/rules/no-this-in-static/) as unsafe by default. - [#​11502](biomejs/biome#11502) [`652aedb`](biomejs/biome@652aedb) Thanks [@​levrik](https://github.com/levrik)! - `noGlobalAssign` no longer reports assignments to a Vue `<script setup>` binding from a template expression, when the binding's name happens to match a built-in global (e.g. `open`, `parent`, `top`). For example, this no longer triggers a diagnostic: ```vue <script setup> const open = defineModel(); </script> <template> <button @click="open = !open">Toggle</button> </template> ``` </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC41Ny4zIiwidXBkYXRlZEluVmVyIjoiNDQuNTcuMyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Reviewed-on: https://git.oirnoir.dev/OIRNOIR/YouTube-Helper-Server/pulls/42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This marks the fixes for
noThisInStaticas unsafe, at least for now. There are too many edge cases.fixes #10278
Test Plan
snapshots
Docs