Skip to content

Build with stable and specified go version - #94

Merged
ties merged 1 commit into
bgp:masterfrom
ties:go-versions
Mar 3, 2023
Merged

ties merged 1 commit into
bgp:masterfrom
ties:go-versions

Conversation

@ties

@ties ties commented Mar 3, 2023

Copy link
Copy Markdown
Collaborator

No description provided.

@ties
ties requested a review from benjojo March 3, 2023 13:56
@ties
ties force-pushed the go-versions branch 4 times, most recently from 2f38154 to 774f324 Compare March 3, 2023 14:09
@ties

ties commented Mar 3, 2023

Copy link
Copy Markdown
Collaborator Author

Finally. Those action things are confusing.

My idea was to build with the latest stable version (= probably what 1.19^'/1.<any> resolves to) as well as with the version we specify in go.mod.

Are there any reasons to move to a more recent go version? If we move to 1.18 we could use generics.

@benjojo

benjojo commented Mar 3, 2023

Copy link
Copy Markdown
Collaborator

If we move to 1.18 we could use generics

Do we need generics?

In general keeping to the lowest version possible (within reason ofc) helps distros build things

@ties

ties commented Mar 3, 2023

Copy link
Copy Markdown
Collaborator Author

Do we need generics?

Could probably be added in a few places. I did not feel the need yet.

In general keeping to the lowest version possible (within reason ofc) helps distros build things

Definitely. Otherwise I would have updated to $latest for both builds. I'll merge this - I think that building with the latest compiler for warnings/etc is good, while also being sure that it builds with the version mentioned in go.mod.

@ties
ties merged commit 54153e9 into bgp:master Mar 3, 2023
@ties
ties deleted the go-versions branch March 3, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants