Skip to content

Add patches making rust analyzer crates deterministic - #3929

Merged
UebelAndre merged 7 commits into
bazelbuild:mainfrom
hofbi:rust-analyzer-crate-determinism-patches
Mar 26, 2026
Merged

UebelAndre merged 7 commits into
bazelbuild:mainfrom
hofbi:rust-analyzer-crate-determinism-patches

Conversation

@hofbi

@hofbi hofbi commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

Kind of related to #3547 but not directly a -sys crate. Regardless, these crates are non deterministic and these patches make them deterministic.

@UebelAndre UebelAndre left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think this is good. This is more of a tool that rules_rust provides and if there's non-determinism in it then we should totally get that patched.

@hofbi

hofbi commented Mar 25, 2026

Copy link
Copy Markdown
Contributor Author

Ideally we should contribute these patches upstream and get rid of them once the new versions are released.

@UebelAndre UebelAndre left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just one thought that should hopefully prevent a regression.

@hofbi
hofbi force-pushed the rust-analyzer-crate-determinism-patches branch from 69f8700 to 981e099 Compare March 26, 2026 11:21
@hofbi

hofbi commented Mar 26, 2026

Copy link
Copy Markdown
Contributor Author

@UebelAndre I think I got it working now.

@hofbi
hofbi requested a review from UebelAndre March 26, 2026 12:06

@UebelAndre UebelAndre left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@UebelAndre
UebelAndre added this pull request to the merge queue Mar 26, 2026
Merged via the queue into bazelbuild:main with commit d84cc49 Mar 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants