Repository navigation
chore(deps): combined dependency upgrades unblocked by #810 - #811
Merged
Merged
Conversation
helly25
requested review from
dzbarsky,
fmeum,
jsharpe and
rrbutani
as code owners
August 3, 2026 20:18
fmeum
approved these changes
Aug 3, 2026
helly25
enabled auto-merge (squash)
August 3, 2026 21:44
This reverts commit bc3404d.
helly25
added a commit
that referenced
this pull request
Aug 4, 2026
…812) ## Summary Re-applies the rules_rust 0.70.0 → 0.73.0 upgrade (#787) that had to be reverted in #811, by first removing the root cause: the unused rules_rust setup in `tests/WORKSPACE`. **Why the upgrade broke hybrid mode:** rules_rust ≥ 0.71 no longer ships `rust/repositories.bzl` (WORKSPACE support removed upstream). In the hybrid CI jobs (Bazel 7/8 with `--enable_bzlmod --enable_workspace`), the root module's `bazel_dep` repos shadow same-named WORKSPACE repos — so the `load("@rules_rust//rust:repositories.bzl", ...)` in `tests/WORKSPACE` resolved to the *bzlmod* rules_rust (not the WORKSPACE-pinned 0.67.0 http_archive) and failed with: ``` ERROR: Error computing the main repository mapping: cannot load '@@rules_rust+//rust:repositories.bzl': no such file ``` This killed every bazel invocation in those jobs, including ones that don't use rust at all (msan). Bazel 9 jobs were unaffected (WORKSPACE is gone there); pure-WORKSPACE jobs (bzlmod=false) were unaffected (no shadowing). **Why removing the WORKSPACE setup is safe:** the rules_rust tests in `run_external_tests.sh` only run with bzlmod enabled (Bazel 9+), and nothing else in the tests workspace uses rust. The WORKSPACE block was dead weight. A comment now documents why it must not be re-added. Closes #787. ## Test plan - CI: the hybrid jobs (7.*/8.* with bzlmod=true) are the ones that failed before the revert in #811; they exercise exactly this path. - Local (macOS arm64): bzlmod analysis of `@rules_rust//test/unit/{interleaved_cc_info,native_deps}:all` at 0.73.0 passed previously on the #811 branch pre-revert; a Bazel 8 hybrid-mode analysis run is in flight and results will be posted here if anything turns up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Collects all outstanding renovate dependency upgrades, which were previously blocked by the Bazel 9.2 / rules_go analysis error fixed in #810. Each commit is the corresponding renovate PR cherry-picked onto current master:
0.70.0 → 0.73.0reverted, stays at 0.70.0Those PRs (except #787) can be closed once this merges (renovate should detect the versions are present).
Why the rules_rust upgrade was reverted: rules_rust 0.73.0 no longer ships
rust/repositories.bzl(WORKSPACE support removed). In the hybrid jobs (Bazel 7/8 with--enable_bzlmod --enable_workspace), the root module'sbazel_deprepos shadow same-named WORKSPACE repos, so theload("@rules_rust//rust:repositories.bzl", ...)intests/WORKSPACEresolves to the bzlmod rules_rust and fails to compute the main repository mapping — breaking every bazel invocation in those jobs (including msan, which doesn't use rust at all). Bazel 9 jobs are unaffected because WORKSPACE is gone there, and pure-WORKSPACE jobs (bzlmod=false) use the separately pinned rules_rust 0.67.0. Taking 0.73.0 requires first removing the rules_rust block fromtests/WORKSPACE(nothing in WORKSPACE mode runs rust tests — the rust targets inrun_external_tests.share gated on bzlmod) or dropping the hybrid-mode CI jobs; left for a follow-up.Verification (local, macOS arm64, Bazel 9.2.0, bzlmod)
@io_bazel_rules_go//tests/core/cgo:all,@rules_rust//test/unit/{interleaved_cc_info,native_deps}:all,@boringssl//...and//foreign:pcreall analyze cleanly (106 targets) — confirming the Fix external tests on Bazel 9.2: patch rules_go duplicate constraints #810 rules_go patch applies to 0.62.0 and the boringssl patch applies to 0.20260803.0.run_external_tests.shall still exist under rules_go 0.62.0, so target-pattern expansion stays valid.Note: rules_go 0.62.0 has a known Bazel 9 issue with duplicate mingw constraints in its windows cgo platforms (bazel-contrib/rules_go#4665); it should not trigger here since nothing targets Windows, but flagging it in case CI says otherwise.