Skip to content

chore(deps): combined dependency upgrades unblocked by #810 - #811

Merged
helly25 merged 8 commits into
bazel-contrib:masterfrom
helly25:deps-combined-upgrades
Aug 4, 2026
Merged

helly25 merged 8 commits into
bazel-contrib:masterfrom
helly25:deps-combined-upgrades

Conversation

@helly25

@helly25 helly25 commented Aug 3, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Collects all outstanding renovate dependency upgrades, which were previously blocked by the Bazel 9.2 / rules_go analysis error fixed in #810. Each commit is the corresponding renovate PR cherry-picked onto current master:

PR Dependency Version
#804 rules_java (WORKSPACE) 9.6.1 → 9.7.0
#805 aspect_bazel_lib (WORKSPACE) 3.5.0 → 3.7.1
#806 bazel_skylib (MODULE + toolchain/deps.bzl) 1.9.0 → 1.9.2
#776 boringssl (MODULE + WORKSPACE) 0.20260526.0 → 0.20260803.0
#787 rules_rust (MODULE) 0.70.0 → 0.73.0 reverted, stays at 0.70.0
#807 io_bazel_rules_go (WORKSPACE) 0.61.1 → 0.62.0
#808 rules_go (MODULE) 0.61.1 → 0.62.0

Those PRs (except #787) can be closed once this merges (renovate should detect the versions are present).

Why the rules_rust upgrade was reverted: rules_rust 0.73.0 no longer ships rust/repositories.bzl (WORKSPACE support removed). In the hybrid jobs (Bazel 7/8 with --enable_bzlmod --enable_workspace), the root module's bazel_dep repos shadow same-named WORKSPACE repos, so the load("@rules_rust//rust:repositories.bzl", ...) in tests/WORKSPACE resolves to the bzlmod rules_rust and fails to compute the main repository mapping — breaking every bazel invocation in those jobs (including msan, which doesn't use rust at all). Bazel 9 jobs are unaffected because WORKSPACE is gone there, and pure-WORKSPACE jobs (bzlmod=false) use the separately pinned rules_rust 0.67.0. Taking 0.73.0 requires first removing the rules_rust block from tests/WORKSPACE (nothing in WORKSPACE mode runs rust tests — the rust targets in run_external_tests.sh are gated on bzlmod) or dropping the hybrid-mode CI jobs; left for a follow-up.

Verification (local, macOS arm64, Bazel 9.2.0, bzlmod)

  • @io_bazel_rules_go//tests/core/cgo:all, @rules_rust//test/unit/{interleaved_cc_info,native_deps}:all, @boringssl//... and //foreign:pcre all analyze cleanly (106 targets) — confirming the Fix external tests on Bazel 9.2: patch rules_go duplicate constraints #810 rules_go patch applies to 0.62.0 and the boringssl patch applies to 0.20260803.0.
  • The test targets excluded in run_external_tests.sh all still exist under rules_go 0.62.0, so target-pattern expansion stays valid.

Note: rules_go 0.62.0 has a known Bazel 9 issue with duplicate mingw constraints in its windows cgo platforms (bazel-contrib/rules_go#4665); it should not trigger here since nothing targets Windows, but flagging it in case CI says otherwise.

@helly25
helly25 enabled auto-merge (squash) August 3, 2026 21:44
@helly25
helly25 merged commit 2793fb2 into bazel-contrib:master Aug 4, 2026
76 checks passed
@helly25
helly25 deleted the deps-combined-upgrades branch August 4, 2026 06:36
helly25 added a commit that referenced this pull request Aug 4, 2026
…812)

## Summary

Re-applies the rules_rust 0.70.0 → 0.73.0 upgrade (#787) that had to be
reverted in #811, by first removing the root cause: the unused
rules_rust setup in `tests/WORKSPACE`.

**Why the upgrade broke hybrid mode:** rules_rust ≥ 0.71 no longer ships
`rust/repositories.bzl` (WORKSPACE support removed upstream). In the
hybrid CI jobs (Bazel 7/8 with `--enable_bzlmod --enable_workspace`),
the root module's `bazel_dep` repos shadow same-named WORKSPACE repos —
so the `load("@rules_rust//rust:repositories.bzl", ...)` in
`tests/WORKSPACE` resolved to the *bzlmod* rules_rust (not the
WORKSPACE-pinned 0.67.0 http_archive) and failed with:

```
ERROR: Error computing the main repository mapping: cannot load '@@rules_rust+//rust:repositories.bzl': no such file
```

This killed every bazel invocation in those jobs, including ones that
don't use rust at all (msan). Bazel 9 jobs were unaffected (WORKSPACE is
gone there); pure-WORKSPACE jobs (bzlmod=false) were unaffected (no
shadowing).

**Why removing the WORKSPACE setup is safe:** the rules_rust tests in
`run_external_tests.sh` only run with bzlmod enabled (Bazel 9+), and
nothing else in the tests workspace uses rust. The WORKSPACE block was
dead weight. A comment now documents why it must not be re-added.

Closes #787.

## Test plan

- CI: the hybrid jobs (7.*/8.* with bzlmod=true) are the ones that
failed before the revert in #811; they exercise exactly this path.
- Local (macOS arm64): bzlmod analysis of
`@rules_rust//test/unit/{interleaved_cc_info,native_deps}:all` at 0.73.0
passed previously on the #811 branch pre-revert; a Bazel 8 hybrid-mode
analysis run is in flight and results will be posted here if anything
turns up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants