Repository navigation
ci: add stdlib matrix testing (libc++, stdc++, dynamic-stdc++) - #726
Merged
Merged
Conversation
Extend external_test to cover all supported stdlib implementations: - default: auto-config (builtin-libc++) - libc++: system/sysroot-hosted libc++ - stdc++: static libstdc++ - dynamic-stdc++: dynamic libstdc++ Restrict bazel to 8.* and latest; exclude bzlmod=false for latest and for non-default stdlibs to keep the matrix manageable. Add llvm_toolchain_libcxx, llvm_toolchain_stdcpp, and llvm_toolchain_dynamic_stdcpp to both MODULE.bazel and WORKSPACE. Update run_external_tests.sh to select toolchain via TEST_STDLIB env var.
helly25
requested review from
dzbarsky,
fmeum,
jsharpe and
rrbutani
as code owners
May 9, 2026 14:10
âĶtch to WORKSPACE - Only run rules_rust and rules_go cgo prep/tests on bazel 9+ with bzlmod enabled, since older versions don't support them reliably. - Add missing boringssl-20260413.0.patch to tests/WORKSPACE to match the bzlmod version in tests/MODULE.bazel.
âĶts.sh Use uname to auto-detect os/arch and build the correct cc-toolchain label (e.g. aarch64-darwin on macOS ARM, x86_64-linux on Linux) instead of hardcoding x86_64-linux everywhere.
Collaborator
Author
|
@fmeum we need to change the required tests since the two external tests now have an additional parameter. It is not clear which ones we want to require. |
Collaborator
Author
|
@phlax take a look if the matrix for the external tests make sense to you please. |
fmeum
approved these changes
May 10, 2026
fmeum
left a comment
Member
There was a problem hiding this comment.
Modifying required checks on GH is an unfortunate experience - I'll do my best
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extend
external_testin.github/workflows/tests.ymlto cover all supported stdlib implementations by adding astdlibmatrix dimension and corresponding test toolchains.What changed
CI matrix (
.github/workflows/tests.yml)The
external_testjob now includes astdlibdimension with four values:defaultbuiltin-libc++libc++stdc++dynamic-stdc++Exclusions to keep the matrix manageable:
builtin-libc++in legacy modeBazel versions: restricted to
8.*andlatest(the old "rules_rust bzlmod support is experimental" comment from 2023 is stale).Test toolchains (
tests/MODULE.bazel+tests/WORKSPACE)Three new toolchain configurations added to both bzlmod and WORKSPACE modes:
llvm_toolchain_libcxxâstdlib = "libc++"llvm_toolchain_stdcppâstdlib = "stdc++"llvm_toolchain_dynamic_stdcppâstdlib = "dynamic-stdc++"Test script (
tests/scripts/run_external_tests.sh)unameto auto-detect the correct toolchain label suffix (aarch64-darwin,x86_64-linux, etc.) instead of hardcodingx86_64-linuxTEST_STDLIBenv var â selects which extra toolchain to pass via--extra_toolchainstargetsarray â all test targets collected into a single array, passed as one-- "${targets[@]}"argument tobazel testWORKSPACE boringssl fix
Added missing
patch_argsandpatchesattributes to the boringsslhttp_archiveintests/WORKSPACEto match the bzlmod version intests/MODULE.bazel.