Skip to content

Fix run_external_tests.sh shellcheck issues - #725

Merged
helly25 merged 1 commit into
bazel-contrib:masterfrom
helly25:fix/run-external-tests-shellcheck
May 8, 2026
Merged

helly25 merged 1 commit into
bazel-contrib:masterfrom
helly25:fix/run-external-tests-shellcheck

Conversation

@helly25

@helly25 helly25 commented May 7, 2026

Copy link
Copy Markdown
Collaborator

Fixes shellcheck issues in run_external_tests.sh and updates .trunk/.gitignore.

Changes:

  • Remove unnecessary quotes around variable references (SC2086)
  • Add blank line after set -euo pipefail for readability
  • Add shellcheck source directive comment
  • Update .trunk/.gitignore to ignore tmp directory

These changes improve script compliance with shellcheck static analysis.

- Remove unnecessary quotes around variable references
- Add blank line after set -euo pipefail
- Add shellcheck source directive comment
- Update .trunk/.gitignore to ignore tmp directory

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@helly25 helly25 closed this May 7, 2026
@helly25
helly25 deleted the fix/run-external-tests-shellcheck branch May 7, 2026 22:40
@helly25
helly25 restored the fix/run-external-tests-shellcheck branch May 7, 2026 22:42
@helly25 helly25 reopened this May 7, 2026
@helly25
helly25 merged commit 0d9d2fe into bazel-contrib:master May 8, 2026
84 of 122 checks passed
@helly25
helly25 deleted the fix/run-external-tests-shellcheck branch May 8, 2026 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants