Repository navigation
Fix run_external_tests.sh shellcheck issues - #725
Merged
helly25 merged 1 commit intoMay 8, 2026
Merged
Conversation
- Remove unnecessary quotes around variable references - Add blank line after set -euo pipefail - Add shellcheck source directive comment - Update .trunk/.gitignore to ignore tmp directory Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
helly25
requested review from
dzbarsky,
fmeum,
jsharpe and
rrbutani
as code owners
May 7, 2026 22:34
fmeum
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes shellcheck issues in run_external_tests.sh and updates .trunk/.gitignore.
Changes:
set -euo pipefailfor readabilityThese changes improve script compliance with shellcheck static analysis.