Skip to content

Make system module map generation faster and fully hermetic - #280

Merged
fmeum merged 1 commit into
bazel-contrib:masterfrom
fmeum:improved-module-map
Mar 14, 2024
Merged

fmeum merged 1 commit into
bazel-contrib:masterfrom
fmeum:improved-module-map

Conversation

@fmeum

@fmeum fmeum commented Mar 3, 2024 •

Copy link
Copy Markdown
Member
  • system_module_maps no longer performs any IO.
  • The generated module map no longer references any non-hermetic paths and can thus be cached remotely, even when toolchain or sysroot are provided as absolute paths.

@fmeum
fmeum force-pushed the improved-module-map branch 5 times, most recently from 3b4d52b to f2ee72f Compare March 4, 2024 11:02
Comment thread toolchain/toolchains.bzl.tpl Resolved
@fmeum
fmeum marked this pull request as ready for review March 4, 2024 11:56

@siddharthab siddharthab left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please land whenever you are ready. Let's make a release when this lands.

Comment thread toolchain/toolchains.bzl.tpl Resolved
@siddharthab siddharthab mentioned this pull request Mar 13, 2024
@fmeum
fmeum force-pushed the improved-module-map branch from f2ee72f to 1a11e9f Compare March 14, 2024 09:49
@fmeum
fmeum enabled auto-merge (squash) March 14, 2024 10:21
@fmeum
fmeum merged commit 81f85c0 into bazel-contrib:master Mar 14, 2024
@fmeum
fmeum deleted the improved-module-map branch March 14, 2024 10:23
jsharpe pushed a commit to jsharpe/bazel-toolchain that referenced this pull request Jun 5, 2024
host_dl_ext = host_dl_ext,
)

def _is_hermetic_or_exists(rctx, path, sysroot_prefix):

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please help me understand how to make RBE work in this case? For example when running bazel from macOS and executing in a remote Linux executor, /usr/include does not exist on macOS but exists on Linux, this filter will remove /usr/include from cxx_builtin_include_directories and that could result in bazel validation failure ...includes the following non-builtin files with absolute paths (if these are builtin files, make sure these paths are in your toolchain).

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't have this scenario in mind when I wrote this, my assumption being that you would only use this toolchain for RBE together with a hermetic sysroot.

This function only makes sense if you are actually targetting the host, so we should probably disable it when cross compiling and just use all directories unfiltered. If you want to give that a try, I can help you implement and test this approach.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. I'm not sure of a reasonable implementation. What would you suggest?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The _is_hermetic_or_exists function should be fed the information whether exec_os equals target_os and only perform the existence check if so.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I was looking at those, but not sure that is reliable. For RBE, exec_os could be the same as target_os, right? For example I can define a toolchain like the following and while produce target for linux as well.

llvm.toolchain(
    name = "llvm_toolchain_linux_exec",
    exec_arch = "amd64",
    exec_os = "linux",
    llvm_version = LLVM_VERSION,
)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are completely right, I guess we need to match the host OS (obtained e.g. from repository_ctx.os) against the target OS (this determines the shape of the sysroot).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me give that a try.

@honnix honnix Nov 7, 2024 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rctx.os.name for mac is like mac os x, which is not the same as the convention used by target_os :( But otherwise this should be a reasonable approach. We just need to do some formalisation.

helly25 added a commit that referenced this pull request May 3, 2026
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[softprops/action-gh-release](https://redirect.github.com/softprops/action-gh-release)
| action | major | `v2` → `v3` |

---

### Release Notes

<details>
<summary>softprops/action-gh-release
(softprops/action-gh-release)</summary>

###
[`v3`](https://redirect.github.com/softprops/action-gh-release/compare/v2...v3)

[Compare
Source](https://redirect.github.com/softprops/action-gh-release/compare/v3.0.0...v3.0.0)

###
[`v3.0.0`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v3.0.0)

[Compare
Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.6.2...v3.0.0)

`3.0.0` is a major release that moves the action runtime from Node 20 to
Node 24.
Use `v3` on GitHub-hosted runners and self-hosted fleets that already
support the
Node 24 Actions runtime. If you still need the last Node 20-compatible
line, stay on
`v2.6.2`.

#### What's Changed

##### Other Changes 🔄

- Move the action runtime and bundle target to Node 24
- Update `@types/node` to the Node 24 line and allow future Dependabot
updates
- Keep the floating major tag on `v3`; `v2` remains pinned to the latest
`2.x` release

###
[`v2.6.2`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.6.2)

[Compare
Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.6.1...v2.6.2)

<!-- Release notes generated using configuration in .github/release.yml
at master -->

#### What's Changed

##### Other Changes 🔄

- chore(deps): bump picomatch from 4.0.3 to 4.0.4 by
[@&#8203;dependabot](https://redirect.github.com/dependabot)\[bot] in
[#&#8203;775](https://redirect.github.com/softprops/action-gh-release/pull/775)
- chore(deps): bump brace-expansion from 5.0.4 to 5.0.5 by
[@&#8203;dependabot](https://redirect.github.com/dependabot)\[bot] in
[#&#8203;777](https://redirect.github.com/softprops/action-gh-release/pull/777)
- chore(deps): bump vite from 8.0.0 to 8.0.5 by
[@&#8203;dependabot](https://redirect.github.com/dependabot)\[bot] in
[#&#8203;781](https://redirect.github.com/softprops/action-gh-release/pull/781)

**Full Changelog**:
<softprops/action-gh-release@v2...v2.6.2>

###
[`v2.6.1`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.6.1)

[Compare
Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.6.0...v2.6.1)

`2.6.1` is a patch release focused on restoring linked discussion thread
creation when
`discussion_category_name` is set. It fixes `#764`, where the
draft-first publish flow
stopped carrying the discussion category through the final publish step.

If you still hit an issue after upgrading, please open a report with the
bug template and include a minimal repro or sanitized workflow snippet
where possible.

#### What's Changed

##### Bug fixes 🐛

- fix: preserve discussion category on publish by
[@&#8203;chenrui333](https://redirect.github.com/chenrui333) in
[#&#8203;765](https://redirect.github.com/softprops/action-gh-release/pull/765)

###
[`v2.6.0`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.6.0)

[Compare
Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.5.3...v2.6.0)

`2.6.0` is a minor release centered on `previous_tag` support for
`generate_release_notes`,
which lets workflows pin GitHub's comparison base explicitly instead of
relying on the default range.
It also includes the recent concurrent asset upload recovery fix, a
`working_directory` docs sync,
a checked-bundle freshness guard for maintainers, and clearer
immutable-prerelease guidance where
GitHub platform behavior imposes constraints on how prerelease asset
uploads can be published.

If you still hit an issue after upgrading, please open a report with the
bug template and include a minimal repro or sanitized workflow snippet
where possible.

#### What's Changed

##### Exciting New Features 🎉

- feat: support previous\_tag for generate\_release\_notes by
[@&#8203;pocesar](https://redirect.github.com/pocesar) in
[#&#8203;372](https://redirect.github.com/softprops/action-gh-release/pull/372)

##### Bug fixes 🐛

- fix: recover concurrent asset metadata 404s by
[@&#8203;chenrui333](https://redirect.github.com/chenrui333) in
[#&#8203;760](https://redirect.github.com/softprops/action-gh-release/pull/760)

##### Other Changes 🔄

- docs: clarify reused draft release behavior by
[@&#8203;chenrui333](https://redirect.github.com/chenrui333) in
[#&#8203;759](https://redirect.github.com/softprops/action-gh-release/pull/759)
- docs: clarify working\_directory input by
[@&#8203;chenrui333](https://redirect.github.com/chenrui333) in
[#&#8203;761](https://redirect.github.com/softprops/action-gh-release/pull/761)
- ci: verify dist bundle freshness by
[@&#8203;chenrui333](https://redirect.github.com/chenrui333) in
[#&#8203;762](https://redirect.github.com/softprops/action-gh-release/pull/762)
- fix: clarify immutable prerelease uploads by
[@&#8203;chenrui333](https://redirect.github.com/chenrui333) in
[#&#8203;763](https://redirect.github.com/softprops/action-gh-release/pull/763)

###
[`v2.5.3`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.5.3)

[Compare
Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.5.2...v2.5.3)

<!-- Release notes generated using configuration in .github/release.yml
at master -->

`2.5.3` is a patch release focused on the remaining path-handling and
release-selection bugs uncovered after `2.5.2`.
It fixes `#639`, `#571`, `#280`, `#614`, `#311`, `#403`, and `#368`.
It also adds documentation clarifications for `#541`, `#645`, `#542`,
`#393`, and `#411`,
where the current behavior is either usage-sensitive or constrained by
GitHub platform limits rather than an action-side runtime bug.

If you still hit an issue after upgrading, please open a report with the
bug template and include a minimal repro or sanitized workflow snippet
where possible.

##### What's Changed

##### Bug fixes 🐛

- fix: prefer token input over GITHUB\_TOKEN by
[@&#8203;chenrui333](https://redirect.github.com/chenrui333) in
[#&#8203;751](https://redirect.github.com/softprops/action-gh-release/pull/751)
- fix: clean up duplicate drafts after canonicalization by
[@&#8203;chenrui333](https://redirect.github.com/chenrui333) in
[#&#8203;753](https://redirect.github.com/softprops/action-gh-release/pull/753)
- fix: support Windows-style file globs by
[@&#8203;chenrui333](https://redirect.github.com/chenrui333) in
[#&#8203;754](https://redirect.github.com/softprops/action-gh-release/pull/754)
- fix: normalize refs-tag inputs by
[@&#8203;chenrui333](https://redirect.github.com/chenrui333) in
[#&#8203;755](https://redirect.github.com/softprops/action-gh-release/pull/755)
- fix: expand tilde file paths by
[@&#8203;chenrui333](https://redirect.github.com/chenrui333) in
[#&#8203;756](https://redirect.github.com/softprops/action-gh-release/pull/756)

##### Other Changes 🔄

- docs: clarify token precedence by
[@&#8203;chenrui333](https://redirect.github.com/chenrui333) in
[#&#8203;752](https://redirect.github.com/softprops/action-gh-release/pull/752)
- docs: clarify GitHub release limits by
[@&#8203;chenrui333](https://redirect.github.com/chenrui333) in
[#&#8203;758](https://redirect.github.com/softprops/action-gh-release/pull/758)
- documentation clarifications for empty-token handling,
`preserve_order`, and special-character asset filename behavior

**Full Changelog**:
<softprops/action-gh-release@v2...v2.5.3>

###
[`v2.5.2`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.5.2)

[Compare
Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.5.1...v2.5.2)

<!-- Release notes generated using configuration in .github/release.yml
at master -->

`2.5.2` is a patch release focused on the remaining release-creation and
prerelease regressions in the `2.5.x` bug-fix cycle.
It fixes `#705`, fixes `#708`, fixes `#740`, fixes `#741`, and fixes
`#722`.
Regression testing covers the shared-tag race, prerelease event
behavior, dotfile asset labels,
same-filename concurrent uploads, and blocked-tag cleanup behavior.

If you still hit an issue after upgrading, please open a report with the
bug template and include a minimal repro or sanitized workflow snippet
where possible.

#### What's Changed

##### Bug fixes 🐛

- fix: canonicalize releases after concurrent create by
[@&#8203;chenrui333](https://redirect.github.com/chenrui333) in
[#&#8203;746](https://redirect.github.com/softprops/action-gh-release/pull/746)
- fix: preserve prereleased events for prereleases by
[@&#8203;chenrui333](https://redirect.github.com/chenrui333) in
[#&#8203;748](https://redirect.github.com/softprops/action-gh-release/pull/748)
- fix: restore dotfile asset labels by
[@&#8203;chenrui333](https://redirect.github.com/chenrui333) in
[#&#8203;749](https://redirect.github.com/softprops/action-gh-release/pull/749)
- fix: handle upload already\_exists races across workflows by
[@&#8203;api2062](https://redirect.github.com/api2062) in
[#&#8203;745](https://redirect.github.com/softprops/action-gh-release/pull/745)
- fix: clean up orphan drafts when tag creation is blocked by
[@&#8203;chenrui333](https://redirect.github.com/chenrui333) in
[#&#8203;750](https://redirect.github.com/softprops/action-gh-release/pull/750)

#### New Contributors

- [@&#8203;api2062](https://redirect.github.com/api2062) made their
first contribution in
[#&#8203;745](https://redirect.github.com/softprops/action-gh-release/pull/745)

**Full Changelog**:
<softprops/action-gh-release@v2...v2.5.2>

###
[`v2.5.1`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.5.1)

[Compare
Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.5.0...v2.5.1)

<!-- Release notes generated using configuration in .github/release.yml
at master -->

`2.5.1` is a patch release focused on regressions introduced in `2.5.0`
and on release lookup reliability.
It fixes `#713`, addresses `#703`, and fixes `#724`. Regression testing
shows that
current `master` no longer reproduces the finalize-race behavior
reported in `#704` and `#709`.

##### What's Changed

##### Bug fixes 🐛

- fix: fetch correct asset URL after finalization; test; some
refactoring by
[@&#8203;pzhlkj6612](https://redirect.github.com/pzhlkj6612) in
[#&#8203;738](https://redirect.github.com/softprops/action-gh-release/pull/738)
- fix: release marked as 'latest' despite make\_latest: false by
[@&#8203;Boshen](https://redirect.github.com/Boshen) in
[#&#8203;715](https://redirect.github.com/softprops/action-gh-release/pull/715)
- fix: use getReleaseByTag API instead of iterating all releases by
[@&#8203;kim-em](https://redirect.github.com/kim-em) in
[#&#8203;725](https://redirect.github.com/softprops/action-gh-release/pull/725)

##### Other Changes 🔄

- dependency updates, including the ESM/runtime compatibility refresh in
[#&#8203;731](https://redirect.github.com/softprops/action-gh-release/pull/731)

##### New Contributors

- [@&#8203;autarch](https://redirect.github.com/autarch) made their
first contribution in
[#&#8203;716](https://redirect.github.com/softprops/action-gh-release/pull/716)
- [@&#8203;pzhlkj6612](https://redirect.github.com/pzhlkj6612) made
their first contribution in
[#&#8203;738](https://redirect.github.com/softprops/action-gh-release/pull/738)
- [@&#8203;Boshen](https://redirect.github.com/Boshen) made their first
contribution in
[#&#8203;715](https://redirect.github.com/softprops/action-gh-release/pull/715)
- [@&#8203;kim-em](https://redirect.github.com/kim-em) made their first
contribution in
[#&#8203;725](https://redirect.github.com/softprops/action-gh-release/pull/725)

**Full Changelog**:
<softprops/action-gh-release@v2...v2.5.1>

###
[`v2.5.0`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.5.0)

[Compare
Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.4.2...v2.5.0)

<!-- Release notes generated using configuration in .github/release.yml
at master -->

#### What's Changed

##### Exciting New Features 🎉

- feat: mark release as draft until all artifacts are uploaded by
[@&#8203;dumbmoron](https://redirect.github.com/dumbmoron) in
[#&#8203;692](https://redirect.github.com/softprops/action-gh-release/pull/692)

##### Other Changes 🔄

- chore(deps): bump the npm group across 1 directory with 5 updates by
[@&#8203;dependabot](https://redirect.github.com/dependabot)\[bot] in
[#&#8203;697](https://redirect.github.com/softprops/action-gh-release/pull/697)
- chore(deps): bump actions/checkout from 5.0.0 to 5.0.1 in the
github-actions group by
[@&#8203;dependabot](https://redirect.github.com/dependabot)\[bot] in
[#&#8203;689](https://redirect.github.com/softprops/action-gh-release/pull/689)

#### New Contributors

- [@&#8203;dumbmoron](https://redirect.github.com/dumbmoron) made their
first contribution in
[#&#8203;692](https://redirect.github.com/softprops/action-gh-release/pull/692)

**Full Changelog**:
<softprops/action-gh-release@v2.4.2...v2.5.0>

###
[`v2.4.2`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.4.2)

[Compare
Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.4.1...v2.4.2)

#### What's Changed

##### Exciting New Features 🎉

- feat: Ensure generated release notes cannot be over 125000 characters
by [@&#8203;BeryJu](https://redirect.github.com/BeryJu) in
[#&#8203;684](https://redirect.github.com/softprops/action-gh-release/pull/684)

##### Other Changes 🔄

- dependency updates

#### New Contributors

- [@&#8203;BeryJu](https://redirect.github.com/BeryJu) made their first
contribution in
[#&#8203;684](https://redirect.github.com/softprops/action-gh-release/pull/684)

**Full Changelog**:
<softprops/action-gh-release@v2.4.1...v2.4.2>

###
[`v2.4.1`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.4.1)

[Compare
Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.4.0...v2.4.1)

<!-- Release notes generated using configuration in .github/release.yml
at master -->

#### What's Changed

##### Other Changes 🔄

- fix(util): support brace expansion globs containing commas in
parseInputFiles by
[@&#8203;Copilot](https://redirect.github.com/Copilot) in
[#&#8203;672](https://redirect.github.com/softprops/action-gh-release/pull/672)
- fix: gracefully fallback to body when body\_path cannot be read by
[@&#8203;Copilot](https://redirect.github.com/Copilot) in
[#&#8203;671](https://redirect.github.com/softprops/action-gh-release/pull/671)

**Full Changelog**:
<softprops/action-gh-release@v2...v2.4.1>

###
[`v2.4.0`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.4.0)

[Compare
Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.3.4...v2.4.0)

<!-- Release notes generated using configuration in .github/release.yml
at master -->

#### What's Changed

##### Exciting New Features 🎉

- feat(action): respect working\_directory for files globs by
[@&#8203;stephenway](https://redirect.github.com/stephenway) in
[#&#8203;667](https://redirect.github.com/softprops/action-gh-release/pull/667)

##### Other Changes 🔄

- chore(deps): bump the npm group with 2 updates by
[@&#8203;dependabot](https://redirect.github.com/dependabot)\[bot] in
[#&#8203;668](https://redirect.github.com/softprops/action-gh-release/pull/668)

**Full Changelog**:
<softprops/action-gh-release@v2.3.4...v2.4.0>

###
[`v2.3.4`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.3.4)

[Compare
Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.3.3...v2.3.4)

<!-- Release notes generated using configuration in .github/release.yml
at master -->

#### What's Changed

##### Bug fixes 🐛

- fix(action): handle 422 already\_exists race condition by
[@&#8203;stephenway](https://redirect.github.com/stephenway) in
[#&#8203;665](https://redirect.github.com/softprops/action-gh-release/pull/665)

##### Other Changes 🔄

- chore(deps): bump actions/setup-node from 4.4.0 to 5.0.0 in the
github-actions group by
[@&#8203;dependabot](https://redirect.github.com/dependabot)\[bot] in
[#&#8203;656](https://redirect.github.com/softprops/action-gh-release/pull/656)
- chore(deps): bump
[@&#8203;types/node](https://redirect.github.com/types/node) from
20.19.11 to 20.19.13 in the npm group by
[@&#8203;dependabot](https://redirect.github.com/dependabot)\[bot] in
[#&#8203;655](https://redirect.github.com/softprops/action-gh-release/pull/655)
- chore(deps): bump vite from 7.0.0 to 7.1.5 by
[@&#8203;dependabot](https://redirect.github.com/dependabot)\[bot] in
[#&#8203;657](https://redirect.github.com/softprops/action-gh-release/pull/657)
- chore(deps): bump the npm group across 1 directory with 2 updates by
[@&#8203;dependabot](https://redirect.github.com/dependabot)\[bot] in
[#&#8203;662](https://redirect.github.com/softprops/action-gh-release/pull/662)
- chore(deps): bump the npm group with 3 updates by
[@&#8203;dependabot](https://redirect.github.com/dependabot)\[bot] in
[#&#8203;666](https://redirect.github.com/softprops/action-gh-release/pull/666)

**Full Changelog**:
<softprops/action-gh-release@v2...v2.3.4>

###
[`v2.3.3`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.3.3)

[Compare
Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.3.2...v2.3.3)

<!-- Release notes generated using configuration in .github/release.yml
at master -->

#### What's Changed

##### Exciting New Features 🎉

- feat: add input option `overwrite_files` by
[@&#8203;asfernandes](https://redirect.github.com/asfernandes) in
[#&#8203;343](https://redirect.github.com/softprops/action-gh-release/pull/343)

##### Other Changes 🔄

- dependency updates

#### New Contributors

- [@&#8203;asfernandes](https://redirect.github.com/asfernandes) made
their first contribution in
[#&#8203;343](https://redirect.github.com/softprops/action-gh-release/pull/343)

**Full Changelog**:
<softprops/action-gh-release@v2...v2.3.3>

###
[`v2.3.2`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.3.2)

[Compare
Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.3.1...v2.3.2)

- fix: revert fs `readableWebStream` change

###
[`v2.3.1`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.3.1)

[Compare
Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.3.0...v2.3.1)

<!-- Release notes generated using configuration in .github/release.yml
at master -->

#### What's Changed

##### Bug fixes 🐛

- fix: fix file closing issue by
[@&#8203;WailGree](https://redirect.github.com/WailGree) in
[#&#8203;629](https://redirect.github.com/softprops/action-gh-release/pull/629)

#### New Contributors

- [@&#8203;WailGree](https://redirect.github.com/WailGree) made their
first contribution in
[#&#8203;629](https://redirect.github.com/softprops/action-gh-release/pull/629)

**Full Changelog**:
<softprops/action-gh-release@v2.3.0...v2.3.1>

###
[`v2.3.0`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.3.0)

[Compare
Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.2.2...v2.3.0)

<!-- Release notes generated using configuration in .github/release.yml
at master -->

- Migrate from jest to vitest
- Replace `mime` with `mime-types`
- Bump to use node 24
- Dependency updates

**Full Changelog**:
<softprops/action-gh-release@v2.2.2...v2.3.0>

###
[`v2.2.2`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.2.2)

[Compare
Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.2.1...v2.2.2)

<!-- Release notes generated using configuration in .github/release.yml
at master -->

#### What's Changed

##### Bug fixes 🐛

- fix: updating release draft status from true to false by
[@&#8203;galargh](https://redirect.github.com/galargh) in
[#&#8203;316](https://redirect.github.com/softprops/action-gh-release/pull/316)

##### Other Changes 🔄

- chore: simplify ref\_type test by
[@&#8203;steinybot](https://redirect.github.com/steinybot) in
[#&#8203;598](https://redirect.github.com/softprops/action-gh-release/pull/598)
- fix(docs): clarify the default for tag\_name by
[@&#8203;muzimuzhi](https://redirect.github.com/muzimuzhi) in
[#&#8203;599](https://redirect.github.com/softprops/action-gh-release/pull/599)
- test(release): add unit tests when searching for a release by
[@&#8203;rwaskiewicz](https://redirect.github.com/rwaskiewicz) in
[#&#8203;603](https://redirect.github.com/softprops/action-gh-release/pull/603)
- dependency updates

#### New Contributors

- [@&#8203;steinybot](https://redirect.github.com/steinybot) made their
first contribution in
[#&#8203;598](https://redirect.github.com/softprops/action-gh-release/pull/598)
- [@&#8203;muzimuzhi](https://redirect.github.com/muzimuzhi) made their
first contribution in
[#&#8203;599](https://redirect.github.com/softprops/action-gh-release/pull/599)
- [@&#8203;galargh](https://redirect.github.com/galargh) made their
first contribution in
[#&#8203;316](https://redirect.github.com/softprops/action-gh-release/pull/316)
- [@&#8203;rwaskiewicz](https://redirect.github.com/rwaskiewicz) made
their first contribution in
[#&#8203;603](https://redirect.github.com/softprops/action-gh-release/pull/603)

**Full Changelog**:
<softprops/action-gh-release@v2.2.1...v2.2.2>

###
[`v2.2.1`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.2.1)

[Compare
Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.2.0...v2.2.1)

<!-- Release notes generated using configuration in .github/release.yml
at master -->

#### What's Changed

##### Bug fixes 🐛

- fix: big file uploads by
[@&#8203;xen0n](https://redirect.github.com/xen0n) in
[#&#8203;562](https://redirect.github.com/softprops/action-gh-release/pull/562)

##### Other Changes 🔄

- chore(deps): bump
[@&#8203;types/node](https://redirect.github.com/types/node) from
22.10.1 to 22.10.2 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[#&#8203;559](https://redirect.github.com/softprops/action-gh-release/pull/559)
- chore(deps): bump
[@&#8203;types/node](https://redirect.github.com/types/node) from
22.10.2 to 22.10.5 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[#&#8203;569](https://redirect.github.com/softprops/action-gh-release/pull/569)
- chore: update error and warning messages for not matching files in
files field by [@&#8203;ytimocin](https://redirect.github.com/ytimocin)
in
[#&#8203;568](https://redirect.github.com/softprops/action-gh-release/pull/568)

#### New Contributors

- [@&#8203;ytimocin](https://redirect.github.com/ytimocin) made their
first contribution in
[#&#8203;568](https://redirect.github.com/softprops/action-gh-release/pull/568)

**Full Changelog**:
<softprops/action-gh-release@v2.2.0...v2.2.1>

###
[`v2.2.0`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.2.0)

[Compare
Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.1.0...v2.2.0)

#### What's Changed

##### Exciting New Features 🎉

- feat: read the release assets asynchronously by
[@&#8203;xen0n](https://redirect.github.com/xen0n) in
[#&#8203;552](https://redirect.github.com/softprops/action-gh-release/pull/552)

##### Bug fixes 🐛

- fix(docs): clarify the default for tag\_name by
[@&#8203;alexeagle](https://redirect.github.com/alexeagle) in
[#&#8203;544](https://redirect.github.com/softprops/action-gh-release/pull/544)

##### Other Changes 🔄

- chore(deps): bump typescript from 5.6.3 to 5.7.2 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[#&#8203;548](https://redirect.github.com/softprops/action-gh-release/pull/548)
- chore(deps): bump
[@&#8203;types/node](https://redirect.github.com/types/node) from 22.9.0
to 22.9.4 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[#&#8203;547](https://redirect.github.com/softprops/action-gh-release/pull/547)
- chore(deps): bump cross-spawn from 7.0.3 to 7.0.6 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[#&#8203;545](https://redirect.github.com/softprops/action-gh-release/pull/545)
- chore(deps): bump
[@&#8203;vercel/ncc](https://redirect.github.com/vercel/ncc) from 0.38.2
to 0.38.3 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[#&#8203;543](https://redirect.github.com/softprops/action-gh-release/pull/543)
- chore(deps): bump prettier from 3.3.3 to 3.4.1 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[#&#8203;550](https://redirect.github.com/softprops/action-gh-release/pull/550)
- chore(deps): bump
[@&#8203;types/node](https://redirect.github.com/types/node) from 22.9.4
to 22.10.1 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[#&#8203;551](https://redirect.github.com/softprops/action-gh-release/pull/551)
- chore(deps): bump prettier from 3.4.1 to 3.4.2 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[#&#8203;554](https://redirect.github.com/softprops/action-gh-release/pull/554)

#### New Contributors

- [@&#8203;alexeagle](https://redirect.github.com/alexeagle) made their
first contribution in
[#&#8203;544](https://redirect.github.com/softprops/action-gh-release/pull/544)
- [@&#8203;xen0n](https://redirect.github.com/xen0n) made their first
contribution in
[#&#8203;552](https://redirect.github.com/softprops/action-gh-release/pull/552)

**Full Changelog**:
<softprops/action-gh-release@v2.1.0...v2.2.0>

###
[`v2.1.0`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.1.0)

[Compare
Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.0.9...v2.1.0)

<!-- Release notes generated using configuration in .github/release.yml
at master -->

#### What's Changed

##### Exciting New Features 🎉

- feat: add support for release assets with multiple spaces within the
name by [@&#8203;dukhine](https://redirect.github.com/dukhine) in
[#&#8203;518](https://redirect.github.com/softprops/action-gh-release/pull/518)
- feat: preserve upload order by
[@&#8203;richarddd](https://redirect.github.com/richarddd) in
[#&#8203;500](https://redirect.github.com/softprops/action-gh-release/pull/500)

##### Other Changes 🔄

- chore(deps): bump
[@&#8203;types/node](https://redirect.github.com/types/node) from 22.8.2
to 22.8.7 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[#&#8203;539](https://redirect.github.com/softprops/action-gh-release/pull/539)

#### New Contributors

- [@&#8203;dukhine](https://redirect.github.com/dukhine) made their
first contribution in
[#&#8203;518](https://redirect.github.com/softprops/action-gh-release/pull/518)
- [@&#8203;richarddd](https://redirect.github.com/richarddd) made their
first contribution in
[#&#8203;500](https://redirect.github.com/softprops/action-gh-release/pull/500)

**Full Changelog**:
<softprops/action-gh-release@v2...v2.1.0>

###
[`v2.0.9`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.0.9)

[Compare
Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.0.8...v2.0.9)

<!-- Release notes generated using configuration in .github/release.yml
at master -->

#### What's Changed

- maintenance release with updated dependencies

#### New Contributors

- [@&#8203;kbakdev](https://redirect.github.com/kbakdev) made their
first contribution in
[#&#8203;521](https://redirect.github.com/softprops/action-gh-release/pull/521)

**Full Changelog**:
<softprops/action-gh-release@v2...v2.0.9>

###
[`v2.0.8`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.0.8)

[Compare
Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.0.7...v2.0.8)

<!-- Release notes generated using configuration in .github/release.yml
at master -->

#### What's Changed

##### Other Changes 🔄

- chore(deps): bump prettier from 2.8.0 to 3.3.3 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[#&#8203;480](https://redirect.github.com/softprops/action-gh-release/pull/480)
- chore(deps): bump
[@&#8203;types/node](https://redirect.github.com/types/node) from
20.14.9 to 20.14.11 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[#&#8203;483](https://redirect.github.com/softprops/action-gh-release/pull/483)
- chore(deps): bump
[@&#8203;octokit/plugin-throttling](https://redirect.github.com/octokit/plugin-throttling)
from 9.3.0 to 9.3.1 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[#&#8203;484](https://redirect.github.com/softprops/action-gh-release/pull/484)
- chore(deps): bump glob from 10.4.2 to 11.0.0 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[#&#8203;477](https://redirect.github.com/softprops/action-gh-release/pull/477)
- refactor: write jest config in ts by
[@&#8203;chenrui333](https://redirect.github.com/chenrui333) in
[#&#8203;485](https://redirect.github.com/softprops/action-gh-release/pull/485)
- chore(deps): bump
[@&#8203;actions/github](https://redirect.github.com/actions/github)
from 5.1.1 to 6.0.0 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[#&#8203;470](https://redirect.github.com/softprops/action-gh-release/pull/470)

**Full Changelog**:
<softprops/action-gh-release@v2...v2.0.8>

###
[`v2.0.7`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.0.7)

[Compare
Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.0.6...v2.0.7)

<!-- Release notes generated using configuration in .github/release.yml
at master -->

#### What's Changed

##### Bug fixes 🐛

- Fix missing update release body by
[@&#8203;FirelightFlagboy](https://redirect.github.com/FirelightFlagboy)
in
[#&#8203;365](https://redirect.github.com/softprops/action-gh-release/pull/365)

##### Other Changes 🔄

- Bump
[@&#8203;octokit/plugin-retry](https://redirect.github.com/octokit/plugin-retry)
from 4.0.3 to 7.1.1 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[#&#8203;443](https://redirect.github.com/softprops/action-gh-release/pull/443)
- Bump typescript from 4.9.5 to 5.5.2 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[#&#8203;467](https://redirect.github.com/softprops/action-gh-release/pull/467)
- Bump [@&#8203;types/node](https://redirect.github.com/types/node) from
20.14.6 to 20.14.8 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[#&#8203;469](https://redirect.github.com/softprops/action-gh-release/pull/469)
- Bump [@&#8203;types/node](https://redirect.github.com/types/node) from
20.14.8 to 20.14.9 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[#&#8203;473](https://redirect.github.com/softprops/action-gh-release/pull/473)
- Bump typescript from 5.5.2 to 5.5.3 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[#&#8203;472](https://redirect.github.com/softprops/action-gh-release/pull/472)
- Bump ts-jest from 29.1.5 to 29.2.2 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[#&#8203;479](https://redirect.github.com/softprops/action-gh-release/pull/479)
- docs: document that existing releases are updated by
[@&#8203;jvanbruegge](https://redirect.github.com/jvanbruegge) in
[#&#8203;474](https://redirect.github.com/softprops/action-gh-release/pull/474)

#### New Contributors

- [@&#8203;jvanbruegge](https://redirect.github.com/jvanbruegge) made
their first contribution in
[#&#8203;474](https://redirect.github.com/softprops/action-gh-release/pull/474)
-
[@&#8203;FirelightFlagboy](https://redirect.github.com/FirelightFlagboy)
made their first contribution in
[#&#8203;365](https://redirect.github.com/softprops/action-gh-release/pull/365)

**Full Changelog**:
<softprops/action-gh-release@v2.0.6...v2.0.7>

###
[`v2.0.6`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.0.6)

[Compare
Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.0.5...v2.0.6)

maintenance release with updated dependencies

###
[`v2.0.5`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.0.5)

[Compare
Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.0.4...v2.0.5)

- Factor in file names with spaces when upserting files
[#&#8203;446](https://redirect.github.com/softprops/action-gh-release/pull/446)
via [@&#8203;MystiPanda](https://redirect.github.com/MystiPanda)
- Improvements to error handling
[#&#8203;449](https://redirect.github.com/softprops/action-gh-release/pull/449)
via [@&#8203;till](https://redirect.github.com/till)

###
[`v2.0.4`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.0.4)

[Compare
Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.0.3...v2.0.4)

- Minor follow up to
[#&#8203;417](https://redirect.github.com/softprops/action-gh-release/pull/417).
[#&#8203;425](https://redirect.github.com/softprops/action-gh-release/pull/425)

###
[`v2.0.3`](https://redirect.github.com/softprops/action-gh-release/compare/v2.0.2...v2.0.3)

[Compare
Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.0.2...v2.0.3)

###
[`v2.0.2`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.0.2)

[Compare
Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.0.1...v2.0.2)

- Revisit approach to
[#&#8203;384](https://redirect.github.com/softprops/action-gh-release/pull/384)
making unresolved pattern failures opt-in
[#&#8203;417](https://redirect.github.com/softprops/action-gh-release/pull/417)

###
[`v2.0.1`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.0.1)

[Compare
Source](https://redirect.github.com/softprops/action-gh-release/compare/v2...v2.0.1)

- Add support for make\_latest property
[#&#8203;304](https://redirect.github.com/softprops/action-gh-release/pull/304)
via [@&#8203;samueljseay](https://redirect.github.com/samueljseay)
- Fail run if files setting contains invalid patterns
[#&#8203;384](https://redirect.github.com/softprops/action-gh-release/pull/384)
via [@&#8203;rpdelaney](https://redirect.github.com/rpdelaney)
- Add support for proxy env variables (don't use node-fetch)
[#&#8203;386/](https://redirect.github.com/softprops/action-gh-release/pull/386/)
via [@&#8203;timor-raiman](https://redirect.github.com/timor-raiman)
- Suppress confusing warning when input\_files is empty
[#&#8203;389](https://redirect.github.com/softprops/action-gh-release/pull/389)
via [@&#8203;Drowze](https://redirect.github.com/Drowze)

</details>

---

### Configuration

📅 **Schedule**: (UTC)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/bazel-contrib/toolchains_llvm).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xMTAuMiIsInVwZGF0ZWRJblZlciI6IjQzLjEzOC4xIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Marcus Boerger <marcus.boerger@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants