Repository navigation
lsp.client: Callers of LSPBindings#getBindingsImpl extect result to be non null - #8789
Merged
Merged
Conversation
…e non null Files whose name starts with vcs- and lie inside the java.io.tmpdir will yield `null` for the call to LSPBindings#getBindingsImpl. This is not expected by callers and breaks the contract of that method that declares it to yield non-null values. This change turns the null into an empty list.
matthiasblaesing
added
LSP
lahodaj
approved these changes
Sep 4, 2025
lahodaj
left a comment
lahodaj
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, thanks!
mbien
approved these changes
Sep 4, 2025
mbien
left a comment
mbien
left a comment
Member
There was a problem hiding this comment.
Thanks! Can confirm that git history works again without NPEs.
Contributor
Author
Switcheeee
approved these changes
Sep 15, 2025
Switcheeee
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Files whose name starts with vcs- and lie inside the java.io.tmpdir will yield
nullfor the call to LSPBindings#getBindingsImpl. This is not expected by callers and breaks the contract of that method that declares it to yield non-null values.This change turns the null into an empty list.