Repository navigation
Avoiding problems when jtreg ClassPathProviderImpl is called from RepositoryUpdater. - #8751
Merged
Merged
Conversation
lahodaj
force-pushed
the
improve-jtreg-root-initialization
branch
from
October 9, 2025 06:07
6b6545a to
56c8118
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a number of hacks to support OpenJDK's test. In particular, those test fail to index reasonably, so under normal circumstances, they are not indexed. And, normally, sourcepath is filtered for non-indexed roots. So, there's a hack that "initializes" the query for the test directory, even if it is not indexed. But - this crashes if, this happens inside RepositoryUpdater task.
The proposal here is to avoid initializing the query when inside the RU task, and initialize later.
^Add meaningful description above
Click to collapse/expand PR instructions
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
Please make sure (eg.
git log) that all commits have a valid name and email address for you in the Author field.If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
PR approval and merge checklist:
If this PR targets the delivery branch: don't merge. (full wiki article)