Skip to content

Avoiding problems when jtreg ClassPathProviderImpl is called from RepositoryUpdater. - #8751

Merged
lahodaj merged 1 commit into
apache:masterfrom
lahodaj:improve-jtreg-root-initialization
Oct 9, 2025
Merged

lahodaj merged 1 commit into
apache:masterfrom
lahodaj:improve-jtreg-root-initialization

Conversation

@lahodaj

@lahodaj lahodaj commented Aug 22, 2025 •

Copy link
Copy Markdown
Contributor

There's a number of hacks to support OpenJDK's test. In particular, those test fail to index reasonably, so under normal circumstances, they are not indexed. And, normally, sourcepath is filtered for non-indexed roots. So, there's a hack that "initializes" the query for the test directory, even if it is not indexed. But - this crashes if, this happens inside RepositoryUpdater task.

The proposal here is to avoid initializing the query when inside the RU task, and initialize later.


^Add meaningful description above

Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

  1. Was this PR correctly labeled, did the right tests run? When did they run?
  2. Is this PR squashed?
  3. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
  4. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

@lahodaj lahodaj added this to the NB28 milestone Aug 22, 2025
@lahodaj
lahodaj requested a review from dbalek August 22, 2025 13:13
@lahodaj lahodaj added the Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) label Aug 22, 2025

@dbalek dbalek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@lahodaj
lahodaj force-pushed the improve-jtreg-root-initialization branch from 6b6545a to 56c8118 Compare October 9, 2025 06:07
@lahodaj
lahodaj merged commit 528587c into apache:master Oct 9, 2025
103 of 105 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants