Repository navigation
Fix getting package export status in a modular project - #8662
Merged
Merged
Conversation
pedro-w
changed the title
mbien
added
the
Java
mbien
reviewed
Aug 25, 2025
mbien
left a comment
mbien
left a comment
Member
There was a problem hiding this comment.
looks good on first glance, added some comments.
feel free to squash / force push
Member
|
on second look: I don't think this will build. Next sync should trigger CI (for some reason it didn't trigger so far). |
Contributor
Author
|
I do apologize, something got lost somewhere along the way. Should now be fixed. I don't know why CI didn't run tests. All tests on that module are passing locally. |
Member
|
awesome, thanks! could you:
It should now be all green. |
pedro-w
force-pushed
the
issue-8560
branch
2 times, most recently
from
August 26, 2025 10:19
5b018b5 to
7352d2b
Compare
mbien
reviewed
Aug 26, 2025
This is instead of getTypeDecls, due to a change in the API between JDK16 and 17.
Contributor
Author
|
ok 🤞 |
mbien
approved these changes
Aug 27, 2025
mbien
left a comment
mbien
left a comment
Member
There was a problem hiding this comment.
thanks for working on the fix and your patience during review
will merge once CI green
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When getting the module definition from a
module-info.javafile, usegetModulerather than scanning throughgetTypeDecls.In the compiler API, the latter used to work up until JDK16, then it was changed for subsequent releases, so that the module object is no longer considered a type declaration. See discussion in #8560.
Tests included (there were no tests for this previously). I have not squashed them so it's possible to see the tests run without the fix. Please advise.
Fixes #8560
Fixes #8614
Click to collapse/expand PR instructions
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
Please make sure (eg.
git log) that all commits have a valid name and email address for you in the Author field.If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
PR approval and merge checklist:
If this PR targets the delivery branch: don't merge. (full wiki article)