Skip to content

Prevent NPE in SemanticHighlighter and fix JsSemanticAnalyser - #8307

Merged
matthiasblaesing merged 2 commits into
apache:masterfrom
matthiasblaesing:handle_broken_semantichighlighter
Mar 10, 2025
Merged

matthiasblaesing merged 2 commits into
apache:masterfrom
matthiasblaesing:handle_broken_semantichighlighter

Conversation

@matthiasblaesing

Copy link
Copy Markdown
Contributor

Closes: #8282

@matthiasblaesing matthiasblaesing added JavaScript [ci] enable web job and extra JavaScript tests (webcommon/javascript2.editor) CSL [ci] enable web job ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Mar 8, 2025
@matthiasblaesing matthiasblaesing added this to the NB26 milestone Mar 8, 2025

@mbien mbien left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@ebarboni

Copy link
Copy Markdown
Contributor

LGTM

@matthiasblaesing

Copy link
Copy Markdown
Contributor Author

Thanks for the reviews. Lets get this in.

@matthiasblaesing
matthiasblaesing merged commit debf00a into apache:master Mar 10, 2025
@matthiasblaesing
matthiasblaesing deleted the handle_broken_semantichighlighter branch October 5, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) CSL [ci] enable web job JavaScript [ci] enable web job and extra JavaScript tests (webcommon/javascript2.editor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NPE on SemanticHighllighters

3 participants