[jGauravGupta]

This PR renames the instance type 'None' default option in Payara Server properties to 'Remote'.

[matthiasblaesing]

@jGauravGupta I think there is a fourth option missing: "Local" and I think this shows another, but related problem. Please follow these steps:

1. Create a local payara instance
2. Check the context menu, you notice, that you have the control options available (the various Start options):
   
3. Open the "Properties" for the entry and Close it again
4. Check context menu again, the options are not available anymore:
   

I think the "local" instance is "converted" to a remote one at that moment.

[matthiasblaesing]

@jGauravGupta this PR moved from target NB25 to NB26, to NB27 and it looks to be postponed again. Want to have another look?

[jGauravGupta]

Hi, sorry for the delayed reply. This option is only visible in the properties for remote instances (Default, WSL, Docker), and is not available for local instances.

[matthiasblaesing]

@jGauravGupta please follow the steps I provided. The issue here is that the local instance I created gets converted into a remove instance.

[jGauravGupta]

Hi,

I have verified that the issue where the local instance gets converted into a remote instance has already been fixed in PR #8542
for NB27.

[matthiasblaesing]

@jGauravGupta Thanks for the reply. Indeed the start/stop action keep working, so that is indeed fixed.

For the naming have a look at this screenshot:

This is a local instance, "Instance Type: Remote" looks a bit strange in this case. I admit though, that "None" is not much better. Would "Remote/Local" or "Normal" make sense?

[jGauravGupta]

Hi @matthiasblaesing, thanks for catching the UX issue. I’m marking the instance type field as visible(false) for local servers.

[mbien]

please rebase before integration. this branch is from ~january looks like.

[matthiasblaesing]

I only did a very quick build/smoke test, but the local instance is now shown without the type label and thus this looks fine to me.

Prior to the built I merged current master into the PR branch, so that observation should be closed to a rebased version.

@jGauravGupta freeze is on October 15th, so would be good if you could rebase+merge soon.