Skip to content

[MENFORCER-490] Declare maven-enforcer-extension dependencies - #282

Merged
elharo merged 3 commits into
masterfrom
deps
Aug 22, 2023
Merged

elharo merged 3 commits into
masterfrom
deps

Conversation

@elharo

@elharo elharo commented Aug 22, 2023

Copy link
Copy Markdown
Contributor

MENFORCER-490 is going to take multiple PRs to work through. This starts with a couple of the simpler fixes.

@slawekjaranowski

Copy link
Copy Markdown
Member

As you see at build result - at least plexus-utils is needed in runtime ....

I suppose that can be a bug in exporting artifacts and classes by Maven classloader itself.

@elharo

elharo commented Aug 22, 2023

Copy link
Copy Markdown
Contributor Author

I suppose that can be a bug in exporting artifacts and classes by Maven classloader itself.

Yes, it's even more complicated than that. The problem isn't that plexus-utils wasn't added to the classpath. It's that two different copies are loaded by separate classloaders. I think we can declare it provided to get around that.

@elharo
elharo merged commit d4ec8e1 into master Aug 22, 2023
@elharo
elharo deleted the deps branch August 22, 2023 16:54
@cstamas

cstamas commented Dec 2, 2023

Copy link
Copy Markdown
Member

This is completely wrong PR: how is plexus-utils provided? It WAS provided in Maven 3.8 and before, but read release notes of Maven 3.9 (same for all 3.9.x version): https://maven.apache.org/docs/3.9.6/release-notes.html#potentially-breaking-core-changes-if-migrating-from-3-8-x

@cstamas

cstamas commented Dec 2, 2023 •

Copy link
Copy Markdown
Member

Stop relying blindly on dependency:analyze output, as it declares many false positives (and negatives), typical example is slf4j-simple etc. Plexus Utils is used but this plugin, hence it must be dependency of it, is definitely not provided!

@jira-importer

Copy link
Copy Markdown

Resolve #883

1 similar comment
@jira-importer

Copy link
Copy Markdown

Resolve #883

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants