Repository navigation
Simplify the Sandbox settings page. - #701
Merged
Merged
Conversation
… presets Network: registries and search (strict folded in) with the machine's own hosts, or allow everything. Credentials list only what was added; shipped entries become presets with the variable each tool reads. A hung docker info no longer fails the OpenShell checklist.
Network allow list holds only the machine's ticked sites, none by default; strict/standard removed. The app no longer installs OpenShell; setup is two checks and one step with progress. DMG build requires grpcio so the sidecar can use OpenShell.
…fault Wire the Tauri opener plugin so openExternal works in the desktop app. Tools list shows only folders this machine has, all switched off until chosen.
…g line A session's sandbox is made when its first turn runs, not at connect or folder pick. The folder step restarts the Homebrew gateway on a Mac and checks the config in use. The preparing line names the real sandbox.
A throwaway container asks the kernel; without Landlock the Docker row says update Docker Desktop. A sandbox that exits at start on such a Mac gets the same message instead of ContainerExited.
rohitprasad15
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Sandbox page asked for too much up front. Needed cleanup.
Additionally, there were some bugs in running OpenShell run on a Mac: the gateway was never restarted after setup, and if User had older Docker Desktop kernels, it did not have Landlock which lead to failures.
What
grpcio, without which OpenShell cannot be used.strictandstandardare gone;sandbox_network_profile = "allowlist"withsandbox_network_hosts.How to try it
Tested
test_tool_result_capfailures are on main too). vitest: 474 pass.Not in this PR