Skip to content

Ensure we enumerate github API pages before concluding - #107

Merged
wagoodman merged 4 commits into
mainfrom
better-wait-check
Jun 1, 2026
Merged

Ensure we enumerate github API pages before concluding#107
wagoodman merged 4 commits into
mainfrom
better-wait-check

Conversation

@wagoodman

@wagoodman wagoodman commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

This makes a few changes:

  • We have only been fetching the first 30 recent checks on a reference, ignoring any additional checks that may exist. This ensures we're checking for the first 10 pages and increasing the page size to 100.
  • If there is no check name we timeout in 10 minutes, but this is wasteful, if we haven't seen the check name (which is different than waiting for simply the status to show up) then we should bail sooner as something is wrong. This timeout has been added and is set to 90.
  • Check names validated are now case insensitive
  • Upon seeing duplicate check names then we will wait on all checks to pass, not just the first we see
  • Added optional verbosity to debug issues as-needed (defaults to false)
  • Will exit immediately on 401 http class issues (github uses 403 to convey secondary rate limits so we should still retry then)
  • I also found that go-make tasks were not showing output --this has also been addressed
  • I've updated the release pipeline to be able to break-glass and release even if checks are failing (given that any bug in this script would prevent updating it!)

wagoodman added 2 commits June 1, 2026 14:18
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
@wagoodman wagoodman added the bug Something isn't working label Jun 1, 2026
wagoodman added 2 commits June 1, 2026 14:43
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
@wagoodman
wagoodman merged commit c8124d0 into main Jun 1, 2026
7 checks passed
@wagoodman
wagoodman deleted the better-wait-check branch June 1, 2026 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant