🏆 ยอดนิยม: agones dev/agones/pull/

lacroixthomas · 2026-08-18T22:08:56Z

What type of PR is this?
/kind cleanup

What this PR does / Why we need it:

Use the new error package (https://github.com/agones-dev/agones/blob/main/pkg/util/errors/errors.go) on the pkg/gameservers/* files

Which issue(s) this PR fixes:

Work on #4510

Did you use AI tools in preparing this PR?:

Y

Special notes for your reviewer:
Many others PRs will follow

Also, not sure about the unit tests, the expected errors are fine, but matching the exact error message hmm not fully sure we want to keep that

Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>

Copilot

Pull request overview

Migrates pkg/gameservers/* error construction/wrapping away from github.com/pkg/errors to the internal pkg/util/errors package, standardizing error prefixes by package/struct origin and updating unit tests to accommodate the new error string format.

Changes:

Replaced github.com/pkg/errors usage with pkg/util/errors across multiple GameServer controllers and helpers, adding per-struct errs helpers (via errors.FromStruct) and a package-level helper (via errors.FromPackage).
Updated error creation/wrapping call sites to use errs.New, errs.Errorf, and errs.Wrap.
Relaxed several tests from exact error string equality to substring checks to avoid brittleness with the new error prefixes/wrapping format.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
pkg/gameservers/succeeded.go	Switches controller error creation/wrapping to `pkg/util/errors` and adds per-controller `errs` helper.
pkg/gameservers/pernodecounter.go	Uses `pkg/util/errors` with a per-struct `errs` helper for cache sync and list errors.
pkg/gameservers/missing.go	Switches controller error creation/wrapping to `pkg/util/errors` and adds per-controller `errs` helper.
pkg/gameservers/migration.go	Switches controller error creation/wrapping to `pkg/util/errors` and adds per-controller `errs` helper.
pkg/gameservers/health.go	Switches controller error creation/wrapping to `pkg/util/errors` and adds per-controller `errs` helper.
pkg/gameservers/health_test.go	Updates assertions to use substring matching for updated error messages.
pkg/gameservers/gameservers.go	Introduces package-level `errs := errors.FromPackage()` and migrates helper functions to `pkg/util/errors`.
pkg/gameservers/gameservers_test.go	Updates assertions to substring matching for updated wrapped/prefixed error messages.
pkg/gameservers/controller.go	Migrates controller and webhook extension error wrapping to `pkg/util/errors` and adds `errs` helpers.
pkg/gameservers/controller_test.go	Updates assertions to substring matching for updated wrapped/prefixed error messages.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

 	if err != nil {
-		return nil, errors.WithStack(err)
+		return nil, err
 	}


agones-bot · 2026-08-18T23:08:12Z

Build Succeeded 🥳

Build Id: a86433ce-7bdb-4f2f-8f11-dd0fb113bb8c

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.61.0-dev-24c4f36
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.61.0-dev-24c4f36
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.61.0-dev-24c4f36-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.61.0-dev-24c4f36
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.61.0-dev-24c4f36
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.61.0-dev-24c4f36
Linux C++ SDK (build): agonessdk-1.61.0-dev-24c4f36-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.61.0-dev-24c4f36.zip

A preview of the website (the last 30 builds are retained):

https://24c4f36-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4691/head:pr_4691 && git checkout pr_4691
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.61.0-dev-24c4f36

Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>

lacroixthomas · 2026-08-19T15:00:50Z

+//
+// Wrapf returns nil if err is nil.
+func (e *Errors) Wrapf(err error, format string, a ...any) error {
+	return e.Wrap(err, fmt.Sprintf(format, a...))


Could also be

if err == nil { return nil } return fmt.Errorf("%s: %w", e.prefix(fmt.Sprintf(format, a...)), err)

Might be clearer with the "prefix" part

I think I like the nil check first - since if the error is nil, then there is no expansion of the Sprintf string - whereas in the it's current format it always gets translated.

agones-bot · 2026-08-19T15:54:34Z

Build Succeeded 🥳

Build Id: 4030b2fa-cd67-43ef-a24d-8a8cd5885e47

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.61.0-dev-f18deb0
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.61.0-dev-f18deb0
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.61.0-dev-f18deb0-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.61.0-dev-f18deb0
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.61.0-dev-f18deb0
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.61.0-dev-f18deb0
Linux C++ SDK (build): agonessdk-1.61.0-dev-f18deb0-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.61.0-dev-f18deb0.zip

A preview of the website (the last 30 builds are retained):

https://f18deb0-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4691/head:pr_4691 && git checkout pr_4691
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.61.0-dev-f18deb0

markmandel · 2026-08-23T01:50:27Z

 		_, err = ext.creationValidationHandler(review)
 		if assert.Error(t, err) {
-			assert.Equal(t, `error unmarshalling GameServer json after schema validation: "WRONG DATA": json: cannot unmarshal string into Go value of type v1.GameServer`, err.Error())
+			assert.Contains(t, err.Error(), `error unmarshalling GameServer json after schema validation: "WRONG DATA": json: cannot unmarshal string into Go value of type v1.GameServer`)


Just being nit picky on the tests 😄

Suggested change

assert.Contains(t, err.Error(), `error unmarshalling GameServer json after schema validation: "WRONG DATA": json: cannot unmarshal string into Go value of type v1.GameServer`)

assert.ErrorContains(t, err, `error unmarshalling GameServer json after schema validation: "WRONG DATA": json: cannot unmarshal string into Go value of type v1.GameServer`)

Same for the rest.

markmandel · 2026-08-23T01:51:42Z

+				if assert.Error(t, err) {
+					assert.Contains(t, err.Error(), v.expected.err)
+				}


Suggested change

if assert.Error(t, err) {

assert.Contains(t, err.Error(), v.expected.err)

}

require.ErrorContains(t, err, v.expected.err)

I assume it needs to be a substring?

markmandel · 2026-08-23T01:53:58Z

+//
+// Wrapf returns nil if err is nil.
+func (e *Errors) Wrapf(err error, format string, a ...any) error {
+	return e.Wrap(err, fmt.Sprintf(format, a...))


I think I like the nil check first - since if the error is nil, then there is no expansion of the Sprintf string - whereas in the it's current format it always gets translated.

Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>

agones-bot · 2026-08-24T22:07:28Z

Build Succeeded 🥳

Build Id: 21e2584d-b389-4e07-9fb4-5e2de52ead4a

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.61.0-dev-c661982
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.61.0-dev-c661982
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.61.0-dev-c661982-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.61.0-dev-c661982
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.61.0-dev-c661982
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.61.0-dev-c661982
Linux C++ SDK (build): agonessdk-1.61.0-dev-c661982-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.61.0-dev-c661982.zip

A preview of the website (the last 30 builds are retained):

https://c661982-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4691/head:pr_4691 && git checkout pr_4691
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.61.0-dev-c661982

agones-bot · 2026-08-28T01:11:38Z

Build Succeeded 🥳

Build Id: db694ddf-acf5-46b6-9994-9bc1b0ea0f92

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.61.0-dev-99fa4dc
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.61.0-dev-99fa4dc
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.61.0-dev-99fa4dc-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.61.0-dev-99fa4dc
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.61.0-dev-99fa4dc
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.61.0-dev-99fa4dc
Linux C++ SDK (build): agonessdk-1.61.0-dev-99fa4dc-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.61.0-dev-99fa4dc.zip

A preview of the website (the last 30 builds are retained):

https://99fa4dc-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4691/head:pr_4691 && git checkout pr_4691
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.61.0-dev-99fa4dc

markmandel · 2026-08-29T07:57:24Z

 }
+
+func TestWrapf(t *testing.T) {
+	sentinel := errors.New("boom")


feat: use new errors pkg in pkg/gameservers/

24c4f36

Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>

github-actions Bot added kind/cleanup Refactoring code, fixing up documentation, etc size/M labels Aug 18, 2026

lacroixthomas requested a lite review from Copilot August 18, 2026 22:15

Copilot started reviewing on behalf of lacroixthomas August 18, 2026 22:15

View session

Copilot AI reviewed Aug 18, 2026

View reviewed changes

Comment thread pkg/gameservers/controller.go

Comment on lines 630 to 632

if err != nil {

return nil, errors.WithStack(err)

return nil, err

}

lacroixthomas marked this pull request as ready for review August 18, 2026 22:20

lacroixthomas requested a review from a team August 18, 2026 22:21

markmandel reviewed Aug 18, 2026

View reviewed changes

Comment thread pkg/gameservers/controller.go Outdated

lacroixthomas added 2 commits August 18, 2026 19:26

feat: use Errorf instead of Wrap

95ed0a0

Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>

feat: add Wrapf errors

f18deb0

Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>

lacroixthomas commented Aug 19, 2026

View reviewed changes

lacroixthomas requested a review from markmandel August 20, 2026 21:13

markmandel reviewed Aug 23, 2026

View reviewed changes

lacroixthomas and others added 3 commits August 24, 2026 17:09

feat: update unit tests

bccd0af

Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>

feat: update Wrapf error util

646017d

Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>

Merge branch 'main' into features/integrate-errors-gameservers-pkg

c661982

Merge branch 'main' into features/integrate-errors-gameservers-pkg

99fa4dc

lacroixthomas requested a review from markmandel August 28, 2026 00:23

markmandel approved these changes Aug 29, 2026

View reviewed changes

markmandel merged commit 1cc6f54 into agones-dev:main Aug 29, 2026
4 checks passed

Navigation Menu

Repository navigation

feat: use new errors pkg in pkg/gameservers/ - #4691

feat: use new errors pkg in pkg/gameservers/#4691
markmandel merged 7 commits into
agones-dev:mainfrom
lacroixthomas:features/integrate-errors-gameservers-pkg

lacroixthomas commented Aug 18, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

agones-bot commented Aug 18, 2026

Uh oh!

Uh oh!

lacroixthomas Aug 19, 2026

Uh oh!

markmandel Aug 23, 2026

Uh oh!

agones-bot commented Aug 19, 2026

Uh oh!

markmandel Aug 23, 2026

Uh oh!

markmandel Aug 23, 2026

Uh oh!

markmandel Aug 23, 2026

Uh oh!

agones-bot commented Aug 24, 2026

Uh oh!

agones-bot commented Aug 28, 2026

Uh oh!

markmandel Aug 29, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	assert.Contains(t, err.Error(), `error unmarshalling GameServer json after schema validation: "WRONG DATA": json: cannot unmarshal string into Go value of type v1.GameServer`)
	assert.ErrorContains(t, err, `error unmarshalling GameServer json after schema validation: "WRONG DATA": json: cannot unmarshal string into Go value of type v1.GameServer`)

Conversation

lacroixthomas commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

agones-bot commented Aug 18, 2026

Uh oh!

Uh oh!

lacroixthomas Aug 19, 2026

Choose a reason for hiding this comment

Uh oh!

markmandel Aug 23, 2026

Choose a reason for hiding this comment

Uh oh!

agones-bot commented Aug 19, 2026

Uh oh!

markmandel Aug 23, 2026

Choose a reason for hiding this comment

Uh oh!

markmandel Aug 23, 2026

Choose a reason for hiding this comment

Uh oh!

markmandel Aug 23, 2026

Choose a reason for hiding this comment

Uh oh!

agones-bot commented Aug 24, 2026

Uh oh!

agones-bot commented Aug 28, 2026

Uh oh!

markmandel Aug 29, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

lacroixthomas commented Aug 18, 2026 •

edited

Loading