[markmandel]

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Making an attempt to solve this flakiness. Let's see if we keep sending the packet, it eventually gets through.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

Also added a small cleanup for when sidecar is not en enabled feature.

[agones-bot]

Build Failed 😭

Build Id: d82c83d6-8e0f-4425-83dc-479e84b25f90

Status: FAILURE

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[markmandel]

/gcbrun

--- FAIL: TestMultiClusterAllocationFromLocal (2.28s)
    --- FAIL: TestMultiClusterAllocationFromLocal/Handle_allocation_request_locally (1.06s)
        controller_test.go:267: 
            	Error Trace:	/go/src/agones.dev/agones/pkg/gameserverallocations/controller_test.go:267
            	Error:      	Received unexpected error:
            	            	json: cannot unmarshal string into Go struct field GameServerAllocation.status of type v1.GameServerAllocationStatus
            	            	failed to unmarshal allocation response: {"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"GameServerAllocation.allocation.agones.dev \"alloc1\" is invalid: [spec.selectors[0].counters: Forbidden: Feature CountsAndLists must be enabled, spec.selectors[0].lists: Forbidden: Feature CountsAndLists must be enabled]","reason":"Invalid","details":{"name":"alloc1","group":"allocation.agones.dev","kind":"GameServerAllocation","causes":[{"reason":"FieldValueForbidden","message":"Forbidden: Feature CountsAndLists must be enabled","field":"spec.selectors[0].counters"},{"reason":"FieldValueForbidden","message":"Forbidden: Feature CountsAndLists must be enabled","field":"spec.selectors[0].lists"}]},"code":422}
            	            	
            	            	agones.dev/agones/pkg/gameserverallocations.executeAllocation
            	            		/go/src/agones.dev/agones/pkg/gameserverallocations/controller_test.go:787
            	            	agones.dev/agones/pkg/gameserverallocations.TestMultiClusterAllocationFromLocal.func1
            	            		/go/src/agones.dev/agones/pkg/gameserverallocations/controller_test.go:266
            	            	testing.tRunner
            	            		/usr/local/go/src/testing/testing.go:2036
            	            	runtime.goexit
            	            		/usr/local/go/src/runtime/asm_amd64.s:1771
            	Test:       	TestMultiClusterAllocationFromLocal/Handle_allocation_request_locally

[agones-bot]

Build Failed 😭

Build Id: e54f8c38-81e9-4170-9c21-b86a1ae5a95d

Status: FAILURE

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[markmandel]

/gcbrun

	helm upgrade --install --atomic --wait --timeout 10m --namespace=agones-system \
	--create-namespace \
	--set agones.image.tag=1.58.0-dev-b0f6125,agones.image.registry="us-docker.pkg.dev/agones-images/ci" \
	--set agones.image.controller.pullPolicy="Always",agones.image.controller.pullSecret= \
	--set agones.image.extensions.pullPolicy="Always",agones.image.allocator.pullPolicy="Always" \
	--set agones.image.ping.pullPolicy="Always",agones.image.sdk.alwaysPull=true \
	--set agones.ping.http.serviceType="LoadBalancer",agones.ping.udp.serviceType="LoadBalancer" \
	--set agones.allocator.service.serviceType="LoadBalancer" \
	--set agones.controller.logLevel="debug" \
	--set agones.crds.cleanupOnDelete=true \
	--set agones.featureGates="PlayerAllocationFilter=true&FleetAutoscaleRequestMetaData=false&PlayerTracking=true&CountsAndLists=false&RollingUpdateFix=false&PortRanges=false&PortPolicyNone=false&ScheduledAutoscaler=false&GKEAutopilotExtendedDurationPods=false&SidecarContainers=false&WasmAutoscaler=true&Example=true" \
	--set agones.allocator.service.loadBalancerIP=35.231.242.117 \
	--set agones.metrics.serviceMonitor.enabled=false \
	 \
	agones /go/src/agones.dev/agones/install/helm/agones/
Release "agones" does not exist. Installing it now.
Error: release agones failed, and has been uninstalled due to atomic being set: context deadline exceeded
make: *** [Makefile:446: install] Error 1

Weird.

[agones-bot]

Build Succeeded 🥳

Build Id: d43de6e1-c284-4c09-9953-e25600dd2d48

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.58.0-dev-1c1841b
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.58.0-dev-1c1841b
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.58.0-dev-1c1841b-linux
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.58.0-dev-1c1841b
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.58.0-dev-1c1841b
• image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.58.0-dev-1c1841b
• Linux C++ SDK (build): agonessdk-1.58.0-dev-1c1841b-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.58.0-dev-1c1841b.zip

A preview of the website (the last 30 builds are retained):

• https://1c1841b-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4562/head:pr_4562 && git checkout pr_4562
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.58.0-dev-1c1841b