Repository navigation
test: cover the "::" grammar boundaries of the IPv6 host parser - #1242
Merged
Merged
Conversation
Member
|
Running tests. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1242 +/- ##
==========================================
+ Coverage 63.25% 63.28% +0.02%
==========================================
Files 39 39
Lines 7699 7699
Branches 3514 3514
==========================================
+ Hits 4870 4872 +2
Misses 749 749
+ Partials 2080 2078 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
anonrig
approved these changes
Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds regression tests for host-parsing boundaries around
::in IPv6literals — group count, per-group hex width, and lone (non-doubled)
leading/trailing colons — that aren't currently exercised by
tests/wpt/urltestdata.json's existing IPv6 cases.Motivated by #1233, which rewrote this parser; the new tests pin down the
exact WHATWG grammar boundaries it (and the scalar fallback) must continue
to enforce, independent of which code path handles a given build.
What's covered
::must elide at least one group (all-8-groups-explicit +::is invalid)::on serialization(only runs of ≥ 2 are, per spec)
::appears elsewhere in the same host
::is invalidlongest valid non-compressed address)
Test plan
ada::urlandada::url_aggregatorbasic_testssuite passes locally (207/207)clang-formatclean (LLVM 22, project config)