Skip to content

Bump actions/attest from v2.4.0 to v3.0.0 - #691

Merged
bdehamer merged 1 commit into
mainfrom
bdehamer/actions-attest-3
Aug 26, 2025
Merged

bdehamer merged 1 commit into
mainfrom
bdehamer/actions-attest-3

Conversation

@bdehamer

Copy link
Copy Markdown
Collaborator

Signed-off-by: Brian DeHamer <bdehamer@github.com>
Copilot AI review requested due to automatic review settings August 26, 2025 23:43
@bdehamer
bdehamer requested a review from a team as a code owner August 26, 2025 23:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the actions/attest GitHub Action from version v2.4.0 to v3.0.0, keeping the dependency current with the latest release.

  • Updates the commit hash and version comment for actions/attest to reflect v3.0.0

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@bdehamer
bdehamer merged commit 57aa2b0 into main Aug 26, 2025
@bdehamer
bdehamer deleted the bdehamer/actions-attest-3 branch August 26, 2025 23:57

@joe10832 joe10832 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot

cdeust added a commit to cdeust/Cortex that referenced this pull request Jul 29, 2026
)

Real dispatch-verification run (30498168023) caught what #246's own
investigation missed: this action's `runs.using: composite` at v2.4.0
still shells out internally to `attest-build-provenance/predicate@1176ef5`
and an older `actions/attest`, both node20 -- a real
"forced to run on Node.js 24" warning fired twice in that run (sbom job,
build job), on an action #246 had listed as needing no change.

v3.0.0's release notes (actions/attest-build-provenance#691, #693) name
the fix directly: "Bump actions/attest ... Bump to node24 runtime" +
"Bump attest-build-provenance/predicate to v2.0.0 ... Bump to node24
runtime". v4.0.0 restructures further: the composite step now calls
actions/attest@v4.1.1 (SHA a1948c3f..., confirmed node24 by reading its
action.yml) directly, dropping the separate predicate step. Inputs are
unchanged (subject-path/subject-digest/subject-name/... identical names
in v4.1.1's action.yml vs our v2 usage) -- no call-site change needed.

Refs #246.
cdeust added a commit to cdeust/Cortex that referenced this pull request Jul 29, 2026
* ci: add a safe workflow_dispatch verification path to release.yml (#246)

Every uses: in .github/workflows/ already resolved to actions/checkout
v7.0.1, actions/cache v6.1.0, actions/upload-artifact v7.0.1,
actions/download-artifact v8.0.1, and github/codeql-action/upload-sarif
v4.37.3 (all node24, confirmed by reading action.yml at each pinned SHA) —
PR #244 bumped these SHAs to their current majors as a side effect of its
hash-pinning pass, ahead of this issue landing. Nothing left to bump.

What remained was #246's AC4: one dispatch-verified green run of each
affected workflow with zero "forced to run on Node.js 24" lines, quoted
in the PR — and AC3: the upload-artifact/download-artifact round trip in
release.yml proven by one real run. release.yml is push-tag-only, so
proving that round trip meant either cutting a real release (out of
scope: it would publish a real PyPI version and GitHub Release for a CI
verification) or adding the seam to test it safely.

Add workflow_dispatch to release.yml, gated so a manual run exercises
checkout/cache/upload-artifact/download-artifact exactly as a real
release would, but never creates a GitHub Release, never attaches
assets to one, and never publishes to PyPI:
- github-release job: if: github.event_name == 'push'
- build job's "Attach attested distributions" step: same guard
  (softprops/action-gh-release creates the tag_name release if absent —
  an unguarded dispatch run would forge one)
- sbom job's "Upload SBOM" step: same guard
- publish-pypi job: only the pypa/gh-action-pypi-publish step is guarded;
  the download-artifact step above it stays unconditional, since that is
  the exact half of the round trip this exists to verify

Refs #246.

* ci(release): bump actions/attest-build-provenance v2.4.0 -> v4.1.1 (#246)

Real dispatch-verification run (30498168023) caught what #246's own
investigation missed: this action's `runs.using: composite` at v2.4.0
still shells out internally to `attest-build-provenance/predicate@1176ef5`
and an older `actions/attest`, both node20 -- a real
"forced to run on Node.js 24" warning fired twice in that run (sbom job,
build job), on an action #246 had listed as needing no change.

v3.0.0's release notes (actions/attest-build-provenance#691, #693) name
the fix directly: "Bump actions/attest ... Bump to node24 runtime" +
"Bump attest-build-provenance/predicate to v2.0.0 ... Bump to node24
runtime". v4.0.0 restructures further: the composite step now calls
actions/attest@v4.1.1 (SHA a1948c3f..., confirmed node24 by reading its
action.yml) directly, dropping the separate predicate step. Inputs are
unchanged (subject-path/subject-digest/subject-name/... identical names
in v4.1.1's action.yml vs our v2 usage) -- no call-site change needed.

Refs #246.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants