Repository navigation
Query loop: Clarify the Max page to show setting #63028
Description
Description
Noticed while working on #63020
In the Query loop block, the 'Items per page', 'Offset', and 'Max page to show' settings are grouped together.
Currently, they're in a popover that opens from the block toolbar. In #63020 they will be moved to the Inspector panel.
Regardlessof their overall placement, I'm not sure these settings should be grouped together.
- 'Items per page' and 'Offset' are more related to the Query properties.
- 'Max page to show' is more related to the Pagination links.
As a user, the 'Max page to show' setting isn't immediately clear to me. I'd tend to think this setting should be better placed, probably in its own section as suggested also by @carolinan
Also, the description:
Limit the pages you want to show, even if the query has more results. To show all pages use 0 (zero).
doesn't clearly explain this setting is about the pagination links. While 'pagination' may be a technical term to avoid, I'd think this setting should be better explained.
Nnte: in #63020 I'm fixing also a setting name typo where I guess 'page' should be plural 'pages' -> 'Max pages to show'.
Step-by-step reproduction instructions
- Add a Query loop block > Start blank > Title & date.
- Click 'Display settings' in the block toolbar.
- Note: after Make usage of the settings icon more consistent #63020 these settings will be placed in the Inspector panel.
- Observe the 'Max page to show' setting is grouped together with 'Items per page' and 'Offset'.
- Observe both the setting name and its description don't clarify very well this setting is related to the pagination links.
Screenshots, screen recording, code snippet
Environment info
No response
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes
Activity
afercia commentedon Sep 20, 2024
Update: after #58207 the 'Max pages to show' setting is now in the Inspector panel, hidden by default. Still, it's not clear it is about the amount of paginated pages.
afercia commentedon Sep 26, 2024
See some additional feedback from #65524 (comment)
ntsekouras commentedon Oct 31, 2024
It's true that this setting is used only
pagination numbers and nextblocks and after a bit of searching it seems it was added in the initial creation of Query Loop block. That was a way more simplified version of what we have now and as it seems it stuck there..We could move this setting to Pagination block but I'm afraid that it's been to long there and might confuse users where to find it, if they need to.
So, do you think a dedicated inspector panel would help here? If yes, let's make this actionable and find the position and copy of the panel and message. --cc @jameskoster
jameskoster commentedon Oct 31, 2024
I don't have a strong opinion about this one. Agree that conceptually it feels more like an option to include on the pagination block, but I expect some users would expect to find it on the Query Loop too.
One thing we might consider is; removing the ability to toggle the option in ToolsPanel if the Query doesn't include a pagination block. Also; add the option to the pagination block and 'sync' it with the one on the Query, so you can edit it in both places? Like I said, I don't feel strongly about this, and I'm not sure it's worth the effort. In general the Query block could use a holistic design audit, like you mentioned many parts of it haven't been touched in years.
afercia commentedon Nov 5, 2024
I'd support this as a step to make the Query block usage clearer. It makes sense to not show settings that don't do anything.
It could be a first step.
afercia commentedon Nov 5, 2024
In a way, this point is also related to the fact this setting doesn't preview in the editor. Changing the setting doesn't show any change, which contributes to the confusion of what this setting does. See #63027