Skip to content

Ensure our lint command excludes the build-scripts directory - #432

Merged
dkotter merged 3 commits into
WordPress:developfrom
dkotter:fix/js-lint
Apr 16, 2026
Merged

dkotter merged 3 commits into
WordPress:developfrom
dkotter:fix/js-lint

Conversation

@dkotter

@dkotter dkotter commented Apr 15, 2026 •

Copy link
Copy Markdown
Contributor

What?

Update our lint-js command to exclude the build-scripts directory.

Why?

Coming out of #340, a new build-scripts directory gets added when scripts are built. Previously we only had a build directory which is automatically excluded from the wp-scripts lint-js script. Without this exclusion, running npm run lint:js timesout for me locally when I have scripts already built as it tries to lint all the JS files in that directory.

How?

Updates both our lint:js and lint:js:fix npm scripts to add --ignore-pattern '/build-scripts/'

Use of AI Tools

None

Testing Instructions

Locally run npm i && npm run build && npm run lint:js and ensure the lint command doesn't timeout

Changelog Entry

Development Update - Ensure our JS lint script excludes the build-scripts directory.

Open WordPress Playground Preview

@dkotter dkotter added this to the 0.8.0 milestone Apr 15, 2026
@dkotter dkotter self-assigned this Apr 15, 2026
@github-actions

github-actions Bot commented Apr 15, 2026 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: dkotter <dkotter@git.wordpress.org>
Co-authored-by: jeffpaul <jeffpaul@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@codecov

codecov Bot commented Apr 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.36%. Comparing base (4fb4234) to head (d644512).
⚠ïļ Report is 10 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #432   +/-   ##
==========================================
  Coverage      68.36%   68.36%           
  Complexity       813      813           
==========================================
  Files             53       53           
  Lines           3945     3945           
==========================================
  Hits            2697     2697           
  Misses          1248     1248           
Flag Coverage Δ
unit 68.36% <Ãļ> (Ãļ)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
ðŸ“Ē Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ïļ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • ðŸ“Ķ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dkotter
dkotter requested a review from jeffpaul April 15, 2026 18:35

@jeffpaul jeffpaul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality continues to work as expected, thanks!

@dkotter
dkotter merged commit 4f5732e into WordPress:develop Apr 16, 2026
18 checks passed
@github-project-automation github-project-automation Bot moved this from Needs review to Done in WordPress AI Roadmap Apr 16, 2026
@dkotter
dkotter deleted the fix/js-lint branch April 16, 2026 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants