Skip to content

ci: add php-ai-client PHPUnit matrix - #39

Merged
jeffpaul merged 14 commits into
WordPress:trunkfrom
superdav42:ci/php-ai-client-phpunit-matrix
Aug 26, 2026
Merged

jeffpaul merged 14 commits into
WordPress:trunkfrom
superdav42:ci/php-ai-client-phpunit-matrix

Conversation

@superdav42

Copy link
Copy Markdown
Member

Summary

  • add a pull-request PHPUnit workflow matrix for php-ai-client 1.3.1 and 1.4.0
  • install each exact client version before running the project's Composer test script
  • limit runs to PHP, Composer, and PHPUnit-related changes

Verification

  • composer update wordpress/php-ai-client --with=wordpress/php-ai-client:1.3.1 --with-all-dependencies --no-interaction --no-progress --prefer-dist --dry-run
  • composer update wordpress/php-ai-client --with=wordpress/php-ai-client:1.4.0 --with-all-dependencies --no-interaction --no-progress --prefer-dist --dry-run
  • composer test — 9 tests, 29 assertions with php-ai-client 1.4.0

For #34


aidevops.sh v3.32.126 plugin for OpenCode v1.18.2

@superdav42
superdav42 requested a review from a team July 15, 2026 19:44
@github-actions

github-actions Bot commented Jul 15, 2026 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: superdav42 <superdav42@git.wordpress.org>
Co-authored-by: jeffpaul <jeffpaul@git.wordpress.org>
Co-authored-by: dkotter <dkotter@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Comment thread .github/workflows/phpunit.yml Outdated
Comment thread .github/workflows/phpunit.yml Outdated
Comment thread .github/workflows/phpunit.yml Outdated
Comment thread .github/workflows/phpunit.yml Outdated
Comment thread .github/workflows/phpunit.yml Outdated
Comment thread .github/workflows/phpunit.yml Outdated
@superdav42

superdav42 commented Aug 16, 2026 •

Copy link
Copy Markdown
Member Author

Addressed the review feedback:

  • defaulted workflow permissions to none and granted contents: read only to the job;
  • retained the fork-sync guard;
  • expanded coverage to PHP 7.4–8.4;
  • set the php-ai-client constraint to ^1.3.1, matching the version bundled with WordPress 7.0;
  • use lowest/latest Composer resolution, so the lower matrix jobs test 1.3.1 while the upper jobs automatically select the newest compatible release;
  • updated actions/checkout to v7.0.1;
  • synced with trunk, where the Composer test script and PHPUnit suite now exist.

WordPress-version combinations are not needed because the unit suite does not bootstrap WordPress; compatibility with WordPress 7.0's bundled client is represented by the 1.3.1 dependency floor. All 12 PHP/dependency matrix jobs and the existing CI jobs pass.

@superdav42
superdav42 requested a review from dkotter August 16, 2026 06:20
@dkotter

dkotter commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

I'm seeing double tests run on this PR and in looking into why, seems we now have another testing workflow merged as part of #40.

So this PR may not be needed or we may want to look at the workflow added in that PR and make any adjustments that have come out of discussion on this PR.

@jeffpaul jeffpaul modified the milestones: 1.1.0, 1.2.0 Aug 17, 2026
@jeffpaul

Copy link
Copy Markdown
Member

@superdav42 can you adjust the work in this PR so that its focused on iterating on https://github.com/WordPress/ai-provider-for-openai/blob/trunk/.github/workflows/ci.yml and removing the specific phpunit.yml in this PR?

@superdav42

superdav42 commented Aug 24, 2026 •

Copy link
Copy Markdown
Member Author

@jeffpaul Adjusted:

  • removed the standalone .github/workflows/phpunit.yml;
  • extended the existing .github/workflows/ci.yml PHPUnit job to test lowest/latest dependencies across PHP 7.4–8.4;
  • retained the fork-sync guard and job-level contents: read permissions;
  • updated both CI checkout steps to the pinned actions/checkout v7.0.1 commit;

@jeffpaul
jeffpaul merged commit 09f8e73 into WordPress:trunk Aug 26, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants