Skip to content

Migrate from old using_directives to Scala-rewritten directives-parser module - #4192

Merged
Gedochao merged 4 commits into
VirtusLab:mainfrom
Gedochao:feature/directives-parser
Apr 17, 2026
Merged

Migrate from old using_directives to Scala-rewritten directives-parser module#4192
Gedochao merged 4 commits into
VirtusLab:mainfrom
Gedochao:feature/directives-parser

Conversation

@Gedochao

@Gedochao Gedochao commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

Fixes #2443
Fixes #3019
Fixes #2382

Checklist

  • tested the solution locally and it works
  • ran the code formatter (scala-cli fmt .)
  • ran scalafix (./mill -i __.fix)
  • ran reference docs auto-generation (./mill -i 'generate-reference-doc[]'.run)

How much have your relied on LLM-based tools in this contribution?

extensively, Cursor + Claude

How was the solution tested?

existing test suites, included unit tests for the new parser module

@Gedochao
Gedochao force-pushed the feature/directives-parser branch 6 times, most recently from 81d5da8 to 51be79e Compare March 25, 2026 10:02
@Gedochao
Gedochao force-pushed the feature/directives-parser branch from 51be79e to 764c924 Compare April 13, 2026 07:32
@Gedochao
Gedochao force-pushed the feature/directives-parser branch from 764c924 to e0799b4 Compare April 16, 2026 09:32
@Gedochao
Gedochao force-pushed the feature/directives-parser branch from aad5f24 to a2092ec Compare April 16, 2026 12:29
@Gedochao
Gedochao force-pushed the feature/directives-parser branch from a2092ec to ac65ddf Compare April 16, 2026 12:48
@Gedochao
Gedochao marked this pull request as ready for review April 17, 2026 11:24
@Gedochao
Gedochao requested review from tgodzik and zielinsky April 17, 2026 11:24

@tgodzik tgodzik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gedochao
Gedochao merged commit 2bee48c into VirtusLab:main Apr 17, 2026
179 of 184 checks passed
@Gedochao
Gedochao deleted the feature/directives-parser branch April 17, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants